Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h

Issue 2937403002: Style fixes in rtcp_packet/ (Closed)
Patch Set: CR response Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h
index fdcce1082a31ba09a6385e68169b005070a337e1..42c2a96ce13d9cb12484c6e01b1f0654f8fa1114 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h
@@ -26,8 +26,8 @@ class Remb : public Psfb {
static constexpr uint8_t kFeedbackMessageType = 15;
static constexpr size_t kMaxNumberOfSsrcs = 0xff;
- Remb() : bitrate_bps_(0) {}
- ~Remb() override {}
+ Remb();
+ ~Remb() override;
// Parse assumes header is already parsed and validated.
bool Parse(const CommonHeader& packet);
@@ -38,16 +38,13 @@ class Remb : public Psfb {
uint64_t bitrate_bps() const { return bitrate_bps_; }
const std::vector<uint32_t>& ssrcs() const { return ssrcs_; }
- protected:
+ size_t BlockLength() const override;
+
bool Create(uint8_t* packet,
size_t* index,
size_t max_length,
RtcpPacket::PacketReadyCallback* callback) const override;
- size_t BlockLength() const override {
- return kHeaderLength + kCommonFeedbackLength + (2 + ssrcs_.size()) * 4;
- }
-
private:
static constexpr uint32_t kUniqueIdentifier = 0x52454D42; // 'R' 'E' 'M' 'B'.
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698