Replace ASSERT(false) by RTC_NOTREACHED().

Replace ASSERT(false) by RTC_NOTREACHED().

This cl was produced by

  git grep -l 'ASSERT(false)' |\
    xargs -n1 sed -i 's/ASSERT(false)/RTC_NOTREACHED()/'

followed by additional includes of base/checks.h in affected files,
git cl format to adjust spacing in webrtc/base/transformadapter.cc.
Finally, to make presubmit happy, one unnamed TODO marker was deleted
in that file.

This is a step towards deletion of base/common.h.

BUG=webrtc:6424
Review-Url: https://codereview.webrtc.org/2625003003
Cr-Commit-Position: refs/heads/master@{#16009}
Committed: https://chromium.googlesource.com/external/webrtc/+/c80e741ad0ab8348a45eddd451e95607689b6c22

[nisse-webrtc, 2017-01-11 12:11:50]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 12:11:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[nisse-webrtc, 2017-01-11 12:14:42]

nisse@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2017-01-11 12:37:18]

lgtm

Thanks for taking the time to split this up into readable chunks!

[commit-bot: I haz the power, 2017-01-11 13:52:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 13:52:13]

Dry run: This issue passed the CQ dry run.

[nisse-webrtc, 2017-01-11 13:54:19]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2017-01-11 13:54:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-11 13:56:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484142859460670, "parent_rev":
"10418acb9790a82aa8f8368c8d6ba2459747149b", "commit_rev":
"c80e741ad0ab8348a45eddd451e95607689b6c22"}

[commit-bot: I haz the power, 2017-01-11 13:56:50]

Description was changed from

==========
Replace ASSERT(false) by RTC_NOTREACHED().

This cl was produced by

  git grep -l 'ASSERT(false)' |\
    xargs -n1 sed -i 's/ASSERT(false)/RTC_NOTREACHED()/'

followed by additional includes of base/checks.h in affected files,
git cl format to adjust spacing in webrtc/base/transformadapter.cc.
Finally, to make presubmit happy, one unnamed TODO marker was deleted
in that file.

This is a step towards deletion of base/common.h.

BUG=webrtc:6424
==========

to

==========
Replace ASSERT(false) by RTC_NOTREACHED().

This cl was produced by

  git grep -l 'ASSERT(false)' |\
    xargs -n1 sed -i 's/ASSERT(false)/RTC_NOTREACHED()/'

followed by additional includes of base/checks.h in affected files,
git cl format to adjust spacing in webrtc/base/transformadapter.cc.
Finally, to make presubmit happy, one unnamed TODO marker was deleted
in that file.

This is a step towards deletion of base/common.h.

BUG=webrtc:6424

Review-Url: https://codereview.webrtc.org/2625003003
Cr-Commit-Position: refs/heads/master@{#16009}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c80e741ad0ab8348a45eddd45...
==========

[commit-bot: I haz the power, 2017-01-11 13:56:50]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c80e741ad0ab8348a45eddd45...