Replace ASSERT(false) by RTC_NOTREACHED().

webrtc/api/webrtcsdp.cc

 /*
  *  Copyright 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/api/webrtcsdp.h"
 
 #include <ctype.h>
 #include <limits.h>
 #include <stdio.h>
 
 #include <algorithm>
 #include <memory>
 #include <string>
 #include <unordered_map>
 #include <vector>
 
 #include "webrtc/api/jsepicecandidate.h"
 #include "webrtc/api/jsepsessiondescription.h"
 #include "webrtc/base/arraysize.h"
+#include "webrtc/base/checks.h"
 #include "webrtc/base/common.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/messagedigest.h"
 #include "webrtc/base/stringutils.h"
 // for RtpExtension
 #include "webrtc/config.h"
 #include "webrtc/media/base/codec.h"
 #include "webrtc/media/base/cryptoparams.h"
 #include "webrtc/media/base/mediaconstants.h"
 #include "webrtc/media/base/rtputils.h"
@@ skipping 621 matching lines @@
 
 static int GetCandidatePreferenceFromType(const std::string& type) {
   int preference = kPreferenceUnknown;
   if (type == cricket::LOCAL_PORT_TYPE) {
     preference = kPreferenceHost;
   } else if (type == cricket::STUN_PORT_TYPE) {
     preference = kPreferenceReflexive;
   } else if (type == cricket::RELAY_PORT_TYPE) {
     preference = kPreferenceRelayed;
   } else {
-    ASSERT(false);
+    RTC_NOTREACHED();
   }
   return preference;
 }
 
 // Get ip and port of the default destination from the |candidates| with the
 // given value of |component_id|. The default candidate should be the one most
 // likely to work, typically IPv4 relay.
 // RFC 5245
 // The value of |component_id| currently supported are 1 (RTP) and 2 (RTCP).
 // TODO: Decide the default destination in webrtcsession and
@@ skipping 556 matching lines @@
   // m=<media> <port> <proto> <fmt>
   // fmt is a list of payload type numbers that MAY be used in the session.
   const char* type = NULL;
   if (media_type == cricket::MEDIA_TYPE_AUDIO)
     type = kMediaTypeAudio;
   else if (media_type == cricket::MEDIA_TYPE_VIDEO)
     type = kMediaTypeVideo;
   else if (media_type == cricket::MEDIA_TYPE_DATA)
     type = kMediaTypeData;
   else
-    ASSERT(false);
+    RTC_NOTREACHED();
 
   std::string fmt;
   if (media_type == cricket::MEDIA_TYPE_VIDEO) {
     const VideoContentDescription* video_desc =
         static_cast<const VideoContentDescription*>(media_desc);
     for (std::vector<cricket::VideoCodec>::const_iterator it =
              video_desc->codecs().begin();
          it != video_desc->codecs().end(); ++it) {
       fmt.append(" ");
       fmt.append(rtc::ToString<int>(it->id));
@@ skipping 568 matching lines @@
     if (it->type() == cricket::LOCAL_PORT_TYPE) {
       type = kCandidateHost;
     } else if (it->type() == cricket::STUN_PORT_TYPE) {
       type = kCandidateSrflx;
     } else if (it->type() == cricket::RELAY_PORT_TYPE) {
       type = kCandidateRelay;
     } else if (it->type() == cricket::PRFLX_PORT_TYPE) {
       type = kCandidatePrflx;
       // Peer reflexive candidate may be signaled for being removed.
     } else {
-      ASSERT(false);
+      RTC_NOTREACHED();
       // Never write out candidates if we don't know the type.
       continue;
     }
 
     InitAttrLine(kAttributeCandidate, &os);
     os << kSdpDelimiterColon
        << it->foundation() << " "
        << it->component() << " "
        << it->protocol() << " "
        << it->priority() << " "
@@ skipping 398 matching lines @@
     case cricket::MEDIA_TYPE_AUDIO:
       *content_name = cricket::CN_AUDIO;
       break;
     case cricket::MEDIA_TYPE_VIDEO:
       *content_name = cricket::CN_VIDEO;
       break;
     case cricket::MEDIA_TYPE_DATA:
       *content_name = cricket::CN_DATA;
       break;
     default:
-      ASSERT(false);
+      RTC_NOTREACHED();
       break;
   }
   if (!ParseContent(message, media_type, mline_index, protocol, payload_types,
                     pos, content_name, bundle_only, media_desc, transport,
                     candidates, error)) {
     delete media_desc;
     return NULL;
   }
   // Sort the codecs according to the m-line fmt list.
   std::unordered_map<int, int> payload_type_preferences;
@@ skipping 961 matching lines @@
     UpdateCodec<AudioContentDescription, cricket::AudioCodec>(
         media_desc, payload_type, feedback_param);
   } else if (media_type == cricket::MEDIA_TYPE_VIDEO) {
     UpdateCodec<VideoContentDescription, cricket::VideoCodec>(
         media_desc, payload_type, feedback_param);
   }
   return true;
 }
 
 }  // namespace webrtc