Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: webrtc/base/httpbase.cc

Issue 2625003003: Replace ASSERT(false) by RTC_NOTREACHED(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/diskcache.cc ('k') | webrtc/base/httpclient.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/httpbase.cc
diff --git a/webrtc/base/httpbase.cc b/webrtc/base/httpbase.cc
index efdc8af8a9eeacff5f1325db64006301bbee5a2a..262edf8c5da3f7631ac4eba963c88aec563c71c1 100644
--- a/webrtc/base/httpbase.cc
+++ b/webrtc/base/httpbase.cc
@@ -16,6 +16,7 @@
#define SEC_E_CERT_EXPIRED (-2146893016)
#endif // !WEBRTC_WIN
+#include "webrtc/base/checks.h"
#include "webrtc/base/common.h"
#include "webrtc/base/httpbase.h"
#include "webrtc/base/logging.h"
@@ -64,7 +65,7 @@ HttpParser::Process(const char* buffer, size_t len, size_t* processed,
*error = HE_NONE;
if (state_ >= ST_COMPLETE) {
- ASSERT(false);
+ RTC_NOTREACHED();
return PR_COMPLETE;
}
@@ -206,7 +207,7 @@ HttpParser::ProcessLine(const char* line, size_t len, HttpError* error) {
break;
default:
- ASSERT(false);
+ RTC_NOTREACHED();
break;
}
@@ -376,7 +377,7 @@ HttpBase::isConnected() const {
bool
HttpBase::attach(StreamInterface* stream) {
if ((mode_ != HM_NONE) || (http_stream_ != NULL) || (stream == NULL)) {
- ASSERT(false);
+ RTC_NOTREACHED();
return false;
}
http_stream_ = stream;
@@ -702,7 +703,7 @@ HttpBase::flush_data() {
}
}
- ASSERT(false);
+ RTC_NOTREACHED();
}
bool
« no previous file with comments | « webrtc/base/diskcache.cc ('k') | webrtc/base/httpclient.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698