Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: webrtc/base/httpclient.cc

Issue 2625003003: Replace ASSERT(false) by RTC_NOTREACHED(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/httpbase.cc ('k') | webrtc/base/httpserver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/httpclient.cc
diff --git a/webrtc/base/httpclient.cc b/webrtc/base/httpclient.cc
index a458590bdb6406adc1509700cbd7092f897ae0b2..63e5bb2703aaebb799daf5a3d52843567820b488 100644
--- a/webrtc/base/httpclient.cc
+++ b/webrtc/base/httpclient.cc
@@ -12,6 +12,7 @@
#include <algorithm>
#include <memory>
#include "webrtc/base/asyncsocket.h"
+#include "webrtc/base/checks.h"
#include "webrtc/base/common.h"
#include "webrtc/base/diskcache.h"
#include "webrtc/base/httpclient.h"
@@ -336,7 +337,7 @@ StreamInterface* HttpClient::GetDocumentStream() {
void HttpClient::start() {
if (base_.mode() != HM_NONE) {
// call reset() to abort an in-progress request
- ASSERT(false);
+ RTC_NOTREACHED();
return;
}
@@ -345,7 +346,7 @@ void HttpClient::start() {
if (request().hasHeader(HH_TRANSFER_ENCODING, NULL)) {
// Exact size must be known on the client. Instead of using chunked
// encoding, wrap data with auto-caching file or memory stream.
- ASSERT(false);
+ RTC_NOTREACHED();
return;
}
@@ -815,7 +816,7 @@ void HttpClient::onHttpComplete(HttpMode mode, HttpError err) {
void HttpClient::onHttpClosed(HttpError err) {
// This shouldn't occur, since we return the stream to the pool upon command
// completion.
- ASSERT(false);
+ RTC_NOTREACHED();
}
//////////////////////////////////////////////////////////////////////
« no previous file with comments | « webrtc/base/httpbase.cc ('k') | webrtc/base/httpserver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698