Replace ASSERT(false) by RTC_NOTREACHED().

webrtc/base/httpclient.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include <time.h>
 #include <algorithm>
 #include <memory>
 #include "webrtc/base/asyncsocket.h"
+#include "webrtc/base/checks.h"
 #include "webrtc/base/common.h"
 #include "webrtc/base/diskcache.h"
 #include "webrtc/base/httpclient.h"
 #include "webrtc/base/httpcommon-inl.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/pathutils.h"
 #include "webrtc/base/socketstream.h"
 #include "webrtc/base/stringencode.h"
 #include "webrtc/base/stringutils.h"
 #include "webrtc/base/thread.h"
@@ skipping 304 matching lines @@
   request().setHeader(HH_HOST, HttpAddress(server_, false), true);
 }
 
 StreamInterface* HttpClient::GetDocumentStream() {
   return base_.GetDocumentStream();
 }
 
 void HttpClient::start() {
   if (base_.mode() != HM_NONE) {
     // call reset() to abort an in-progress request
-    ASSERT(false);
+    RTC_NOTREACHED();
     return;
   }
 
   ASSERT(!IsCacheActive());
 
   if (request().hasHeader(HH_TRANSFER_ENCODING, NULL)) {
     // Exact size must be known on the client.  Instead of using chunked
     // encoding, wrap data with auto-caching file or memory stream.
-    ASSERT(false);
+    RTC_NOTREACHED();
     return;
   }
 
   attempt_ = 0;
 
   // If no content has been specified, using length of 0.
   request().setHeader(HH_CONTENT_LENGTH, "0", false);
 
   if (!agent_.empty()) {
     request().setHeader(HH_USER_AGENT, agent_, false);
@@ skipping 449 matching lines @@
   } else if (CS_READING == cache_state_) {
     cache_state_ = CS_READY;
   }
   release();
   SignalHttpClientComplete(this, err);
 }
 
 void HttpClient::onHttpClosed(HttpError err) {
   // This shouldn't occur, since we return the stream to the pool upon command
   // completion.
-  ASSERT(false);
+  RTC_NOTREACHED();
 }
 
 //////////////////////////////////////////////////////////////////////
 // HttpClientDefault
 //////////////////////////////////////////////////////////////////////
 
 HttpClientDefault::HttpClientDefault(SocketFactory* factory,
                                      const std::string& agent,
                                      HttpTransaction* transaction)
     : ReuseSocketPool(factory ? factory : Thread::Current()->socketserver()),
       HttpClient(agent, NULL, transaction) {
   set_pool(this);
 }
 
 //////////////////////////////////////////////////////////////////////
 
 }  // namespace rtc