Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: webrtc/base/diskcache.cc

Issue 2625003003: Replace ASSERT(false) by RTC_NOTREACHED(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/autodetectproxy.cc ('k') | webrtc/base/httpbase.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/diskcache.cc
diff --git a/webrtc/base/diskcache.cc b/webrtc/base/diskcache.cc
index 233d2ab43093fc0a448e02ef1c3f8ac3719690f6..207a1afa1bf73d0dfc875ae25dd324e88172d01e 100644
--- a/webrtc/base/diskcache.cc
+++ b/webrtc/base/diskcache.cc
@@ -18,6 +18,7 @@
#include <memory>
#include "webrtc/base/arraysize.h"
+#include "webrtc/base/checks.h"
#include "webrtc/base/common.h"
#include "webrtc/base/diskcache.h"
#include "webrtc/base/fileutils.h"
@@ -262,7 +263,7 @@ std::string DiskCache::IdToFilename(const std::string& id, size_t index) const {
#else // !TRANSPARENT_CACHE_NAMES
// We might want to just use a hash of the filename at some point, both for
// obfuscation, and to avoid both filename length and escaping issues.
- ASSERT(false);
+ RTC_NOTREACHED();
#endif // !TRANSPARENT_CACHE_NAMES
char extension[32];
@@ -319,7 +320,7 @@ void DiskCache::ReleaseResource(const std::string& id, size_t index) const {
const Entry* entry = GetEntry(id);
if (!entry) {
LOG_F(LS_WARNING) << "Missing cache entry";
- ASSERT(false);
+ RTC_NOTREACHED();
return;
}
« no previous file with comments | « webrtc/base/autodetectproxy.cc ('k') | webrtc/base/httpbase.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698