Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: webrtc/p2p/base/pseudotcp.cc

Issue 2625003003: Replace ASSERT(false) by RTC_NOTREACHED(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/base/port.cc ('k') | webrtc/p2p/base/relayserver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/pseudotcp.cc
diff --git a/webrtc/p2p/base/pseudotcp.cc b/webrtc/p2p/base/pseudotcp.cc
index 44893747cced237f03e7b7cee7beb4686ce22371..03c8814ef407bf3e59ddaf374d037160395f3e6f 100644
--- a/webrtc/p2p/base/pseudotcp.cc
+++ b/webrtc/p2p/base/pseudotcp.cc
@@ -21,6 +21,7 @@
#include "webrtc/base/basictypes.h"
#include "webrtc/base/bytebuffer.h"
#include "webrtc/base/byteorder.h"
+#include "webrtc/base/checks.h"
#include "webrtc/base/common.h"
#include "webrtc/base/logging.h"
#include "webrtc/base/socket.h"
@@ -291,7 +292,7 @@ void PseudoTcp::NotifyClock(uint32_t now) {
// Check if it's time to retransmit a segment
if (m_rto_base && (rtc::TimeDiff32(m_rto_base + m_rx_rto, now) <= 0)) {
if (m_slist.empty()) {
- ASSERT(false);
+ RTC_NOTREACHED();
} else {
// Note: (m_slist.front().xmit == 0)) {
// retransmit segments
@@ -378,7 +379,7 @@ void PseudoTcp::GetOption(Option opt, int* value) {
} else if (opt == OPT_RCVBUF) {
*value = m_rbuf_len;
} else {
- ASSERT(false);
+ RTC_NOTREACHED();
}
}
void PseudoTcp::SetOption(Option opt, int value) {
@@ -393,7 +394,7 @@ void PseudoTcp::SetOption(Option opt, int value) {
ASSERT(m_state == TCP_LISTEN);
resizeReceiveBuffer(value);
} else {
- ASSERT(false);
+ RTC_NOTREACHED();
}
}
@@ -735,7 +736,7 @@ bool PseudoTcp::process(Segment& seg) {
<< " rto: " << m_rx_rto;
#endif // _DEBUGMSG
} else {
- ASSERT(false);
+ RTC_NOTREACHED();
}
}
« no previous file with comments | « webrtc/p2p/base/port.cc ('k') | webrtc/p2p/base/relayserver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698