Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: webrtc/p2p/base/port.cc

Issue 2625003003: Replace ASSERT(false) by RTC_NOTREACHED(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/base/port.h ('k') | webrtc/p2p/base/pseudotcp.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/port.cc
diff --git a/webrtc/p2p/base/port.cc b/webrtc/p2p/base/port.cc
index dc99a338d5ed82b98ea8185a812d9bb74b9e235d..e4cf097dc842a7ef091509ad8ed5ea7df0980fd8 100644
--- a/webrtc/p2p/base/port.cc
+++ b/webrtc/p2p/base/port.cc
@@ -16,6 +16,7 @@
#include "webrtc/p2p/base/common.h"
#include "webrtc/p2p/base/portallocator.h"
#include "webrtc/base/base64.h"
+#include "webrtc/base/checks.h"
#include "webrtc/base/crc32.h"
#include "webrtc/base/helpers.h"
#include "webrtc/base/logging.h"
@@ -538,7 +539,7 @@ bool Port::MaybeIceRoleConflict(
}
break;
default:
- ASSERT(false);
+ RTC_NOTREACHED();
}
return ret;
}
@@ -791,7 +792,7 @@ class ConnectionRequest : public StunRequest {
request->AddAttribute(new StunUInt64Attribute(
STUN_ATTR_ICE_CONTROLLED, connection_->port()->IceTiebreaker()));
} else {
- ASSERT(false);
+ RTC_NOTREACHED();
}
// Adding PRIORITY Attribute.
@@ -1039,7 +1040,7 @@ void Connection::OnReadPacket(
break;
default:
- ASSERT(false);
+ RTC_NOTREACHED();
break;
}
}
« no previous file with comments | « webrtc/p2p/base/port.h ('k') | webrtc/p2p/base/pseudotcp.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698