Replace ASSERT(false) by RTC_NOTREACHED().

webrtc/p2p/base/port.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/p2p/base/port.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "webrtc/p2p/base/common.h"
 #include "webrtc/p2p/base/portallocator.h"
 #include "webrtc/base/base64.h"
+#include "webrtc/base/checks.h"
 #include "webrtc/base/crc32.h"
 #include "webrtc/base/helpers.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/messagedigest.h"
 #include "webrtc/base/network.h"
 #include "webrtc/base/stringencode.h"
 #include "webrtc/base/stringutils.h"
 
 namespace {
 
@@ skipping 502 matching lines @@
           SignalRoleConflict(this);
         } else {
           // Send Role Conflict (487) error response.
           SendBindingErrorResponse(stun_msg, addr,
               STUN_ERROR_ROLE_CONFLICT, STUN_ERROR_REASON_ROLE_CONFLICT);
           ret = false;
         }
       }
       break;
     default:
-      ASSERT(false);
+      RTC_NOTREACHED();
   }
   return ret;
 }
 
 void Port::CreateStunUsername(const std::string& remote_username,
                               std::string* stun_username_attr_str) const {
   stun_username_attr_str->clear();
   *stun_username_attr_str = remote_username;
   stun_username_attr_str->append(":");
   stun_username_attr_str->append(username_fragment());
@@ skipping 232 matching lines @@
       }
       if (connection_->nomination() &&
           connection_->nomination() != connection_->acked_nomination()) {
         request->AddAttribute(new StunUInt32Attribute(
             STUN_ATTR_NOMINATION, connection_->nomination()));
       }
     } else if (connection_->port()->GetIceRole() == ICEROLE_CONTROLLED) {
       request->AddAttribute(new StunUInt64Attribute(
           STUN_ATTR_ICE_CONTROLLED, connection_->port()->IceTiebreaker()));
     } else {
-      ASSERT(false);
+      RTC_NOTREACHED();
     }
 
     // Adding PRIORITY Attribute.
     // Changing the type preference to Peer Reflexive and local preference
     // and component id information is unchanged from the original priority.
     // priority = (2^24)*(type preference) +
     //           (2^8)*(local preference) +
     //           (2^0)*(256 - component ID)
     uint32_t type_preference =
         (connection_->local_candidate().protocol() == TCP_PROTOCOL_NAME)
@@ skipping 227 matching lines @@
         break;
 
       // Remote end point sent an STUN indication instead of regular binding
       // request. In this case |last_ping_received_| will be updated but no
       // response will be sent.
       case STUN_BINDING_INDICATION:
         ReceivedPing();
         break;
 
       default:
-        ASSERT(false);
+        RTC_NOTREACHED();
         break;
     }
   }
 }
 
 void Connection::HandleBindingRequest(IceMessage* msg) {
   // This connection should now be receiving.
   ReceivedPing();
 
   const rtc::SocketAddress& remote_addr = remote_candidate_.address();
@@ skipping 529 matching lines @@
     ASSERT(sent < 0);
     error_ = port_->GetError();
     stats_.sent_discarded_packets++;
   } else {
     send_rate_tracker_.AddSamples(sent);
   }
   return sent;
 }
 
 }  // namespace cricket