Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: webrtc/base/physicalsocketserver.cc

Issue 2625003003: Replace ASSERT(false) by RTC_NOTREACHED(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/network.cc ('k') | webrtc/base/signalthread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/physicalsocketserver.cc
diff --git a/webrtc/base/physicalsocketserver.cc b/webrtc/base/physicalsocketserver.cc
index bf2f2c64f8ce7ea2d667a3dec178e01c315ef45b..5efc1a6cea1c8ff272a7e65852a4de986c382701 100644
--- a/webrtc/base/physicalsocketserver.cc
+++ b/webrtc/base/physicalsocketserver.cc
@@ -42,6 +42,7 @@
#include "webrtc/base/arraysize.h"
#include "webrtc/base/basictypes.h"
#include "webrtc/base/byteorder.h"
+#include "webrtc/base/checks.h"
#include "webrtc/base/common.h"
#include "webrtc/base/logging.h"
#include "webrtc/base/networkmonitor.h"
@@ -479,7 +480,7 @@ int PhysicalSocket::EstimateMTU(uint16_t* mtu) {
}
}
- ASSERT(false);
+ RTC_NOTREACHED();
return -1;
#elif defined(WEBRTC_MAC)
// No simple way to do this on Mac OS X.
@@ -595,7 +596,7 @@ int PhysicalSocket::TranslateOption(Option opt, int* slevel, int* sopt) {
case OPT_RTP_SENDTIME_EXTN_ID:
return -1; // No logging is necessary as this not a OS socket option.
default:
- ASSERT(false);
+ RTC_NOTREACHED();
return -1;
}
return 0;
@@ -854,7 +855,7 @@ class EventDispatcher : public Dispatcher {
}
}
- void OnEvent(uint32_t ff, int err) override { ASSERT(false); }
+ void OnEvent(uint32_t ff, int err) override { RTC_NOTREACHED(); }
int GetDescriptor() override { return afd_[0]; }
@@ -1499,7 +1500,7 @@ bool PhysicalSocketServer::Wait(int cmsWait, bool process_io) {
// Failed?
// TODO(pthatcher): need a better strategy than this!
WSAGetLastError();
- ASSERT(false);
+ RTC_NOTREACHED();
return false;
} else if (dw == WSA_WAIT_TIMEOUT) {
// Timeout?
« no previous file with comments | « webrtc/base/network.cc ('k') | webrtc/base/signalthread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698