Replace ASSERT(false) by RTC_NOTREACHED().

webrtc/api/dtmfsender.cc

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/api/dtmfsender.h"
 
 #include <ctype.h>
 
 #include <string>
 
+#include "webrtc/base/checks.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/thread.h"
 
 namespace webrtc {
 
 enum {
   MSG_DO_INSERT_DTMF = 0,
 };
 
 // RFC4733
@@ skipping 130 matching lines @@
   return inter_tone_gap_;
 }
 
 void DtmfSender::OnMessage(rtc::Message* msg) {
   switch (msg->message_id) {
     case MSG_DO_INSERT_DTMF: {
       DoInsertDtmf();
       break;
     }
     default: {
-      ASSERT(false);
+      RTC_NOTREACHED();
       break;
     }
   }
 }
 
 void DtmfSender::DoInsertDtmf() {
   ASSERT(signaling_thread_->IsCurrent());
 
   // Get the first DTMF tone from the tone buffer. Unrecognized characters will
   // be ignored and skipped.
   size_t first_tone_pos = tones_.find_first_of(kDtmfValidTones);
   int code = 0;
   if (first_tone_pos == std::string::npos) {
     tones_.clear();
     // Fire a “OnToneChange” event with an empty string and stop.
     if (observer_) {
       observer_->OnToneChange(std::string());
     }
     return;
   } else {
     char tone = tones_[first_tone_pos];
     if (!GetDtmfCode(tone, &code)) {
       // The find_first_of(kDtmfValidTones) should have guarantee |tone| is
       // a valid DTMF tone.
-      ASSERT(false);
+      RTC_NOTREACHED();
     }
   }
 
   int tone_gap = inter_tone_gap_;
   if (code == kDtmfCodeTwoSecondDelay) {
     // Special case defined by WebRTC - The character',' indicates a delay of 2
     // seconds before processing the next character in the tones parameter.
     tone_gap = kDtmfTwoSecondInMs;
   } else {
     if (!provider_) {
@@ skipping 27 matching lines @@
   LOG(LS_INFO) << "The Dtmf provider is deleted. Clear the sending queue.";
   StopSending();
   provider_ = NULL;
 }
 
 void DtmfSender::StopSending() {
   signaling_thread_->Clear(this);
 }
 
 }  // namespace webrtc