Replace ASSERT(false) by RTC_NOTREACHED().

webrtc/base/socketpool.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include <iomanip>
 
 #include "webrtc/base/asyncsocket.h"
+#include "webrtc/base/checks.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/socketfactory.h"
 #include "webrtc/base/socketpool.h"
 #include "webrtc/base/socketstream.h"
 #include "webrtc/base/thread.h"
 
 namespace rtc {
 
 ///////////////////////////////////////////////////////////////////////////////
 // StreamCache - Caches a set of open streams, defers creation to a separate
@@ skipping 51 matching lines @@
       } else {
         // Monitor open streams
         stream->SignalEvent.connect(this, &StreamCache::OnStreamEvent);
         LOG_F(LS_VERBOSE) << "Caching stream";
         cached_.push_front(*it);
       }
       active_.erase(it);
       return;
     }
   }
-  ASSERT(false);
+  RTC_NOTREACHED();
 }
 
 void StreamCache::OnStreamEvent(StreamInterface* stream, int events, int err) {
   if ((events & SE_CLOSE) == 0) {
     LOG_F(LS_WARNING) << "(" << events << ", " << err
                       << ") received non-close event";
     return;
   }
   for (ConnectedList::iterator it = cached_.begin(); it != cached_.end();
        ++it) {
     if (stream == it->second) {
       LOG_F(LS_VERBOSE) << "(" << it->first << ")";
       // We don't cache closed streams, so return it.
       it->second->SignalEvent.disconnect(this);
       LOG_F(LS_VERBOSE) << "Returning closed stream";
       pool_->ReturnConnectedStream(it->second);
       cached_.erase(it);
       return;
     }
   }
-  ASSERT(false);
+  RTC_NOTREACHED();
 }
 
 //////////////////////////////////////////////////////////////////////
 // NewSocketPool
 //////////////////////////////////////////////////////////////////////
 
 NewSocketPool::NewSocketPool(SocketFactory* factory) : factory_(factory) {
 }
 
 NewSocketPool::~NewSocketPool() {
@@ skipping 154 matching lines @@
 
 void LoggingPoolAdapter::ReturnConnectedStream(StreamInterface* stream) {
   LoggingAdapter* logging = static_cast<LoggingAdapter*>(stream);
   pool_->ReturnConnectedStream(logging->Detach());
   recycle_bin_.push_back(logging);
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 
 } // namespace rtc