Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: webrtc/api/webrtcsdp.cc

Issue 2625003003: Replace ASSERT(false) by RTC_NOTREACHED(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/test/fakeaudiocapturemodule.cc ('k') | webrtc/api/webrtcsdp_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/webrtcsdp.cc
diff --git a/webrtc/api/webrtcsdp.cc b/webrtc/api/webrtcsdp.cc
index 2c1ba640f8e7d1bcca654a09cb188bf2d6bfb1f8..dc701a42986af1ee6ca6e101cfa2809384775041 100644
--- a/webrtc/api/webrtcsdp.cc
+++ b/webrtc/api/webrtcsdp.cc
@@ -23,6 +23,7 @@
#include "webrtc/api/jsepicecandidate.h"
#include "webrtc/api/jsepsessiondescription.h"
#include "webrtc/base/arraysize.h"
+#include "webrtc/base/checks.h"
#include "webrtc/base/common.h"
#include "webrtc/base/logging.h"
#include "webrtc/base/messagedigest.h"
@@ -664,7 +665,7 @@ static int GetCandidatePreferenceFromType(const std::string& type) {
} else if (type == cricket::RELAY_PORT_TYPE) {
preference = kPreferenceRelayed;
} else {
- ASSERT(false);
+ RTC_NOTREACHED();
}
return preference;
}
@@ -1241,7 +1242,7 @@ void BuildMediaDescription(const ContentInfo* content_info,
else if (media_type == cricket::MEDIA_TYPE_DATA)
type = kMediaTypeData;
else
- ASSERT(false);
+ RTC_NOTREACHED();
std::string fmt;
if (media_type == cricket::MEDIA_TYPE_VIDEO) {
@@ -1830,7 +1831,7 @@ void BuildCandidate(const std::vector<Candidate>& candidates,
type = kCandidatePrflx;
// Peer reflexive candidate may be signaled for being removed.
} else {
- ASSERT(false);
+ RTC_NOTREACHED();
// Never write out candidates if we don't know the type.
continue;
}
@@ -2249,7 +2250,7 @@ static C* ParseContentDescription(const std::string& message,
*content_name = cricket::CN_DATA;
break;
default:
- ASSERT(false);
+ RTC_NOTREACHED();
break;
}
if (!ParseContent(message, media_type, mline_index, protocol, payload_types,
« no previous file with comments | « webrtc/api/test/fakeaudiocapturemodule.cc ('k') | webrtc/api/webrtcsdp_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698