Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: webrtc/base/transformadapter.cc

Issue 2625003003: Replace ASSERT(false) by RTC_NOTREACHED(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/stream.cc ('k') | webrtc/base/win32filesystem.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/transformadapter.cc
diff --git a/webrtc/base/transformadapter.cc b/webrtc/base/transformadapter.cc
index d6d85b53724f6cd2028757eb4db5cf89041528b4..798a3c39068b268ccb16bcd2a0ece0256f95bda6 100644
--- a/webrtc/base/transformadapter.cc
+++ b/webrtc/base/transformadapter.cc
@@ -12,6 +12,7 @@
#include <string.h>
+#include "webrtc/base/checks.h"
#include "webrtc/base/common.h"
namespace rtc {
@@ -122,7 +123,7 @@ TransformAdapter::Write(const void * data, size_t data_len,
// Note: Don't signal SR_EOS this iteration, unless no data written
state_ = ST_COMPLETE;
} else if (result == SR_ERROR) {
- ASSERT(false); // When this happens, think about what should be done
+ RTC_NOTREACHED(); // When this happens, think about what should be done
state_ = ST_ERROR;
error_ = -1; // TODO: propagate error
break;
@@ -140,7 +141,7 @@ TransformAdapter::Write(const void * data, size_t data_len,
&subwritten,
&error_);
if (result == SR_BLOCK) {
- ASSERT(false); // TODO: we should handle this
+ RTC_NOTREACHED(); // We should handle this
return SR_BLOCK;
} else if (result == SR_ERROR) {
state_ = ST_ERROR;
« no previous file with comments | « webrtc/base/stream.cc ('k') | webrtc/base/win32filesystem.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698