Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2408133008: GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. (Closed)

Created:
4 years, 2 months ago by kjellander_webrtc
Modified:
4 years, 2 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, tlegrand-webrtc, qiang.lu, peah-webrtc, bjornv1, video-team_agora.io, tterriberry_mozilla.com, fengyue_agora.io, sdk-team_agora.io, minyue-webrtc, mflodman, Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, kwiberg-webrtc, danilchap, henrika_webrtc, audio-team_agora.io, hlundin-webrtc, niklas.enbom, the sun, perkj_webrtc, aluebs-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. These suppressions are causing GN errors when Chromium targets are depending directly on WebRTC targets (needed for https://codereview.chromium.org/2413103004) BUG=webrtc:4256 NOTRY=True Committed: https://crrev.com/e40a7ee0074e1bbb954e9bfbf8fabb7f73ec5d01 Cr-Commit-Position: refs/heads/master@{#14644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -274 lines) Patch
M webrtc/BUILD.gn View 8 chunks +16 lines, -24 lines 0 comments Download
M webrtc/api/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/audio/BUILD.gn View 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/BUILD.gn View 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/common_audio/BUILD.gn View 4 chunks +8 lines, -12 lines 0 comments Download
M webrtc/common_video/BUILD.gn View 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/examples/BUILD.gn View 5 chunks +10 lines, -15 lines 0 comments Download
M webrtc/libjingle/xmpp/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/logging/BUILD.gn View 3 chunks +6 lines, -9 lines 0 comments Download
M webrtc/media/BUILD.gn View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 11 chunks +22 lines, -28 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/bitrate_controller/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/congestion_controller/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/media_file/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/pacing/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/utility/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/video_capture/BUILD.gn View 4 chunks +8 lines, -12 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 8 chunks +16 lines, -24 lines 0 comments Download
M webrtc/modules/video_processing/BUILD.gn View 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/p2p/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/pc/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/sdk/BUILD.gn View 3 chunks +6 lines, -9 lines 0 comments Download
M webrtc/stats/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/system_wrappers/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/test/BUILD.gn View 6 chunks +12 lines, -18 lines 0 comments Download
M webrtc/test/fuzzers/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/tools/BUILD.gn View 6 chunks +12 lines, -18 lines 0 comments Download
M webrtc/video/BUILD.gn View 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 5 chunks +10 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
kjellander_webrtc
4 years, 2 months ago (2016-10-13 16:49:23 UTC) #4
ehmaldonado_webrtc
On 2016/10/13 16:49:23, kjellander_webrtc wrote: LGTM. I wonder if it will compile in Chromium. What ...
4 years, 2 months ago (2016-10-14 00:55:34 UTC) #5
kjellander_webrtc
On 2016/10/14 00:55:34, ehmaldonado_webrtc wrote: > On 2016/10/13 16:49:23, kjellander_webrtc wrote: > > LGTM. > ...
4 years, 2 months ago (2016-10-17 06:39:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2408133008/1
4 years, 2 months ago (2016-10-17 06:39:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 06:56:15 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 06:56:28 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e40a7ee0074e1bbb954e9bfbf8fabb7f73ec5d01
Cr-Commit-Position: refs/heads/master@{#14644}

Powered by Google App Engine
This is Rietveld 408576698