GN: Exclude suppressions of Chromium Clang warnings for Chromium builds.

webrtc/test/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../build/webrtc.gni")
 import("//build/config/ui.gni")
@@ skipping 20 matching lines @@
   testonly = true
   sources = [
     "fake_texture_frame.cc",
     "fake_texture_frame.h",
     "frame_generator.cc",
     "frame_generator.h",
     "frame_utils.cc",
     "frame_utils.h",
   ]
 
-  if (is_clang && !is_nacl) {
-    # Suppress warnings from the Chromium Clang plugin.
-    # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+  if (!build_with_chromium && is_clang) {
+    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 
   deps = [
     "../common_video",
   ]
 }
 
 rtc_source_set("rtp_test_utils") {
   testonly = true
   sources = [
     "rtcp_packet_parser.cc",
     "rtcp_packet_parser.h",
     "rtp_file_reader.cc",
     "rtp_file_reader.h",
     "rtp_file_writer.cc",
     "rtp_file_writer.h",
   ]
 
-  if (is_clang && !is_nacl) {
-    # Suppress warnings from the Chromium Clang plugin.
-    # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+  if (!build_with_chromium && is_clang) {
+    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 
   deps = [
     "..:webrtc_common",
     "../modules/rtp_rtcp",
     "//testing/gtest",
   ]
 }
 
@@ skipping 54 matching lines @@
   deps = [
     ":video_test_common",
     "../base:gtest_prod",
     "../base:rtc_base_approved",
     "../common_video",
     "../system_wrappers",
     "//testing/gmock",
     "//testing/gtest",
   ]
 
-  if (is_clang) {
-    # Suppress warnings from the Chromium Clang plugin.
-    # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+  if (!build_with_chromium && is_clang) {
+    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 
   if (is_ios) {
     configs += [ "//build/config/compiler:enable_arc" ]
   }
 
   if (use_x11) {
     deps += [ "//tools/xdisplaycheck" ]
   }
@@ skipping 80 matching lines @@
     "testsupport/unittest_utils.h",
   ]
 
   # TODO(jschuh): Bug 1348: fix this warning.
   configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
 
   if (is_win) {
     cflags = [ "/wd4373" ]  # virtual override w/different const/volatile signature.
   }
 
-  if (is_clang) {
-    # Suppress warnings from the Chromium Clang plugin.
-    # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+  if (!build_with_chromium && is_clang) {
+    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 
   data = test_support_unittests_resources
   if (is_android) {
     deps += [ "//testing/android/native_test:native_test_support" ]
     shard_timeout = 900
   }
 
   if (is_ios) {
@@ skipping 50 matching lines @@
     "video_capturer.h",
     "win/run_loop_win.cc",
   ]
   if (!is_win) {
     sources += [
       "run_loop.cc",
       "run_loop.h",
     ]
   }
 
-  if (is_clang && !is_nacl) {
-    # Suppress warnings from the Chromium Clang plugin.
-    # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+  if (!build_with_chromium && is_clang) {
+    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 
   deps = [
     ":rtp_test_utils",
     ":test_support",
     "..:webrtc_common",
     "../audio",
     "../base:rtc_base_approved",
     "../call",
@@ skipping 57 matching lines @@
   if (is_mac) {
     libs = [
       "Cocoa.framework",
       "OpenGL.framework",
       "CoreVideo.framework",
     ]
   }
 
   public_configs = [ ":test_renderer_exported_config" ]
 
-  if (is_clang && !is_nacl) {
-    # Suppress warnings from the Chromium Clang plugin.
-    # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+  if (!build_with_chromium && is_clang) {
+    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 
   deps = [
     ":test_support",
     ":video_test_common",
     "../modules/media_file",
     "//testing/gtest",
   ]
 }