| Index: webrtc/modules/audio_coding/BUILD.gn
|
| diff --git a/webrtc/modules/audio_coding/BUILD.gn b/webrtc/modules/audio_coding/BUILD.gn
|
| index 80c1be81fd3b2b3102bad118c92ea66a5baf3894..078fb4bccccaf8aae144366bf0d707249af04181 100644
|
| --- a/webrtc/modules/audio_coding/BUILD.gn
|
| +++ b/webrtc/modules/audio_coding/BUILD.gn
|
| @@ -884,8 +884,8 @@ rtc_source_set("neteq_test_minimal") {
|
| "neteq/tools/neteq_test.h",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163).
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
| }
|
| @@ -952,9 +952,8 @@ if (rtc_include_tests) {
|
| "test/insert_packet_with_timing.cc",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from Chrome's Clang plugins.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -989,8 +988,8 @@ if (rtc_include_tests) {
|
| "neteq/audio_decoder_unittest.cc",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163).
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -1036,9 +1035,8 @@ if (rtc_include_tests) {
|
| "neteq/tools/rtc_event_log_source.h",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from the Chromium Clang plugins
|
| - # (bugs.webrtc.org/163).
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -1058,9 +1056,8 @@ if (rtc_include_tests) {
|
| "neteq/tools/neteq_rtpplay.cc",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from the Chromium Clang plugins
|
| - # (bugs.webrtc.org/163).
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -1092,9 +1089,8 @@ if (rtc_include_tests) {
|
| "codecs/tools/audio_codec_speed_test.h",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from the Chromium Clang plugins
|
| - # (bugs.webrtc.org/163).
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -1122,8 +1118,8 @@ if (rtc_include_tests) {
|
| "neteq/tools/neteq_performance_test.h",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163).
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -1142,8 +1138,8 @@ if (rtc_include_tests) {
|
| "neteq/tools/neteq_quality_test.h",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163).
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -1194,8 +1190,8 @@ if (rtc_include_tests) {
|
|
|
| public_configs = [ ":neteq_unittest_tools_config" ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163).
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -1367,9 +1363,8 @@ if (rtc_include_tests) {
|
| "//third_party/gflags:gflags",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from Chrome's Clang plugins.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
| }
|
| @@ -1618,9 +1613,8 @@ if (rtc_include_tests) {
|
| "//testing/gtest",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from Chrome's Clang plugins.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
| }
|
|
|