Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: webrtc/sdk/BUILD.gn

Issue 2408133008: GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/pc/BUILD.gn ('k') | webrtc/stats/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The WebRTC project authors. All Rights Reserved. 1 # Copyright 2016 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../build/webrtc.gni") 9 import("../build/webrtc.gni")
10 if (is_mac) { 10 if (is_mac) {
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 ] 187 ]
188 } 188 }
189 189
190 configs += [ 190 configs += [
191 "..:common_objc", 191 "..:common_objc",
192 "//build/config/compiler:enable_arc", 192 "//build/config/compiler:enable_arc",
193 ] 193 ]
194 194
195 public_configs = [ ":rtc_sdk_common_objc_config" ] 195 public_configs = [ ":rtc_sdk_common_objc_config" ]
196 196
197 if (is_clang) { 197 if (!build_with_chromium && is_clang) {
198 # Suppress warnings from the Chromium Clang plugins. 198 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
199 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
200 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 199 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
201 } 200 }
202 201
203 libs += [ "AVFoundation.framework" ] 202 libs += [ "AVFoundation.framework" ]
204 203
205 deps = [ 204 deps = [
206 ":rtc_sdk_common_objc", 205 ":rtc_sdk_common_objc",
207 "../api:libjingle_peerconnection", 206 "../api:libjingle_peerconnection",
208 ] 207 ]
209 208
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 "VideoToolbox.framework", 279 "VideoToolbox.framework",
281 ] 280 ]
282 281
283 configs += [ 282 configs += [
284 "..:common_objc", 283 "..:common_objc",
285 "//build/config/compiler:enable_arc", 284 "//build/config/compiler:enable_arc",
286 ] 285 ]
287 286
288 public_configs = [ ":rtc_sdk_common_objc_config" ] 287 public_configs = [ ":rtc_sdk_common_objc_config" ]
289 288
290 if (is_clang) { 289 if (!build_with_chromium && is_clang) {
291 # Suppress warnings from the Chromium Clang plugins. 290 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163)
292 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
293 configs -= [ "//build/config/clang:find_bad_constructs" ] 291 configs -= [ "//build/config/clang:find_bad_constructs" ]
294 } 292 }
295 } 293 }
296 } 294 }
297 if (is_ios) { 295 if (is_ios) {
298 ios_framework_bundle("rtc_sdk_framework_objc") { 296 ios_framework_bundle("rtc_sdk_framework_objc") {
299 info_plist = "objc/Framework/Info.plist" 297 info_plist = "objc/Framework/Info.plist"
300 output_name = "WebRTC" 298 output_name = "WebRTC"
301 299
302 sources = common_objc_headers 300 sources = common_objc_headers
(...skipping 21 matching lines...) Expand all
324 "VideoToolbox.framework", 322 "VideoToolbox.framework",
325 ] 323 ]
326 324
327 configs += [ 325 configs += [
328 "..:common_objc", 326 "..:common_objc",
329 "//build/config/compiler:enable_arc", 327 "//build/config/compiler:enable_arc",
330 ] 328 ]
331 329
332 public_configs = [ ":rtc_sdk_common_objc_config" ] 330 public_configs = [ ":rtc_sdk_common_objc_config" ]
333 331
334 if (is_clang) { 332 if (!build_with_chromium && is_clang) {
335 # Suppress warnings from the Chromium Clang plugins. 333 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163)
336 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
337 configs -= [ "//build/config/clang:find_bad_constructs" ] 334 configs -= [ "//build/config/clang:find_bad_constructs" ]
338 } 335 }
339 } 336 }
340 } 337 }
341 338
342 rtc_static_library("rtc_sdk_objc") { 339 rtc_static_library("rtc_sdk_objc") {
343 complete_static_lib = true 340 complete_static_lib = true
344 deps = [ 341 deps = [
345 ":rtc_sdk_peerconnection_objc", 342 ":rtc_sdk_peerconnection_objc",
346 "../system_wrappers:field_trial_default", 343 "../system_wrappers:field_trial_default",
347 "../system_wrappers:metrics_default", 344 "../system_wrappers:metrics_default",
348 ] 345 ]
349 } 346 }
350 } 347 }
OLDNEW
« no previous file with comments | « webrtc/pc/BUILD.gn ('k') | webrtc/stats/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698