Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: webrtc/logging/BUILD.gn

Issue 2408133008: GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/libjingle/xmpp/BUILD.gn ('k') | webrtc/media/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../build/webrtc.gni") 9 import("../build/webrtc.gni")
10 import("//third_party/protobuf/proto_library.gni") 10 import("//third_party/protobuf/proto_library.gni")
(...skipping 21 matching lines...) Expand all
32 deps = [ 32 deps = [
33 ":rtc_event_log_api", 33 ":rtc_event_log_api",
34 "..:webrtc_common", 34 "..:webrtc_common",
35 "../modules/rtp_rtcp", 35 "../modules/rtp_rtcp",
36 ] 36 ]
37 37
38 if (rtc_enable_protobuf) { 38 if (rtc_enable_protobuf) {
39 defines += [ "ENABLE_RTC_EVENT_LOG" ] 39 defines += [ "ENABLE_RTC_EVENT_LOG" ]
40 deps += [ ":rtc_event_log_proto" ] 40 deps += [ ":rtc_event_log_proto" ]
41 } 41 }
42 if (is_clang && !is_nacl) { 42 if (!build_with_chromium && is_clang) {
43 # Suppress warnings from Chrome's Clang plugins. 43 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
44 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
45 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 44 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
46 } 45 }
47 } 46 }
48 47
49 if (rtc_include_tests) { 48 if (rtc_include_tests) {
50 rtc_source_set("rtc_event_log_tests") { 49 rtc_source_set("rtc_event_log_tests") {
51 testonly = true 50 testonly = true
52 sources = [ 51 sources = [
53 "rtc_event_log/ringbuffer_unittest.cc", 52 "rtc_event_log/ringbuffer_unittest.cc",
54 "rtc_event_log/rtc_event_log_unittest.cc", 53 "rtc_event_log/rtc_event_log_unittest.cc",
55 "rtc_event_log/rtc_event_log_unittest_helper.cc", 54 "rtc_event_log/rtc_event_log_unittest_helper.cc",
56 ] 55 ]
57 deps = [ 56 deps = [
58 ":rtc_event_log_impl", 57 ":rtc_event_log_impl",
59 ":rtc_event_log_parser", 58 ":rtc_event_log_parser",
60 "../modules/rtp_rtcp", 59 "../modules/rtp_rtcp",
61 "../system_wrappers:metrics_default", 60 "../system_wrappers:metrics_default",
62 "//testing/gmock", 61 "//testing/gmock",
63 "//testing/gtest", 62 "//testing/gtest",
64 ] 63 ]
65 if (is_clang) { 64 if (!build_with_chromium && is_clang) {
66 # Suppress warnings from the Chromium Clang plugin. 65 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
67 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
68 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 66 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
69 } 67 }
70 } 68 }
71 } 69 }
72 70
73 if (rtc_enable_protobuf) { 71 if (rtc_enable_protobuf) {
74 proto_library("rtc_event_log_proto") { 72 proto_library("rtc_event_log_proto") {
75 sources = [ 73 sources = [
76 "rtc_event_log/rtc_event_log.proto", 74 "rtc_event_log/rtc_event_log.proto",
77 ] 75 ]
78 proto_out_dir = "webrtc/logging/rtc_event_log" 76 proto_out_dir = "webrtc/logging/rtc_event_log"
79 } 77 }
80 } 78 }
81 79
82 if (rtc_enable_protobuf) { 80 if (rtc_enable_protobuf) {
83 rtc_static_library("rtc_event_log_parser") { 81 rtc_static_library("rtc_event_log_parser") {
84 sources = [ 82 sources = [
85 "rtc_event_log/rtc_event_log_parser.cc", 83 "rtc_event_log/rtc_event_log_parser.cc",
86 "rtc_event_log/rtc_event_log_parser.h", 84 "rtc_event_log/rtc_event_log_parser.h",
87 ] 85 ]
88 86
89 public_deps = [ 87 public_deps = [
90 ":rtc_event_log_proto", 88 ":rtc_event_log_proto",
91 "..:webrtc_common", 89 "..:webrtc_common",
92 ] 90 ]
93 91
94 if (is_clang && !is_nacl) { 92 if (!build_with_chromium && is_clang) {
95 # Suppress warnings from Chrome's Clang plugins. 93 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
96 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
97 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 94 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
98 } 95 }
99 } 96 }
100 } 97 }
OLDNEW
« no previous file with comments | « webrtc/libjingle/xmpp/BUILD.gn ('k') | webrtc/media/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698