| Index: webrtc/test/BUILD.gn
|
| diff --git a/webrtc/test/BUILD.gn b/webrtc/test/BUILD.gn
|
| index 6e494c76befd03b7a2ce5ad7c40a3328989a96b6..5a1e71aa9ab22a8c8b61bb32e431ba26aaf956b3 100644
|
| --- a/webrtc/test/BUILD.gn
|
| +++ b/webrtc/test/BUILD.gn
|
| @@ -38,9 +38,8 @@ rtc_source_set("video_test_common") {
|
| "frame_utils.h",
|
| ]
|
|
|
| - if (is_clang && !is_nacl) {
|
| - # Suppress warnings from the Chromium Clang plugin.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -60,9 +59,8 @@ rtc_source_set("rtp_test_utils") {
|
| "rtp_file_writer.h",
|
| ]
|
|
|
| - if (is_clang && !is_nacl) {
|
| - # Suppress warnings from the Chromium Clang plugin.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -137,9 +135,8 @@ rtc_source_set("test_support") {
|
| "//testing/gtest",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from the Chromium Clang plugin.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -240,9 +237,8 @@ rtc_test("test_support_unittests") {
|
| cflags = [ "/wd4373" ] # virtual override w/different const/volatile signature.
|
| }
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from the Chromium Clang plugin.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -313,9 +309,8 @@ rtc_source_set("test_common") {
|
| ]
|
| }
|
|
|
| - if (is_clang && !is_nacl) {
|
| - # Suppress warnings from the Chromium Clang plugin.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -393,9 +388,8 @@ rtc_source_set("test_renderer") {
|
|
|
| public_configs = [ ":test_renderer_exported_config" ]
|
|
|
| - if (is_clang && !is_nacl) {
|
| - # Suppress warnings from the Chromium Clang plugin.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
|
|