Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: webrtc/common_audio/BUILD.gn

Issue 2408133008: GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/call/BUILD.gn ('k') | webrtc/common_video/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("//build/config/arm.gni") 9 import("//build/config/arm.gni")
10 import("../build/webrtc.gni") 10 import("../build/webrtc.gni")
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 "signal_processing/spl_sqrt_floor.c", 167 "signal_processing/spl_sqrt_floor.c",
168 ] 168 ]
169 } 169 }
170 170
171 if (is_win) { 171 if (is_win) {
172 cflags = [ "/wd4334" ] # Ignore warning on shift operator promotion. 172 cflags = [ "/wd4334" ] # Ignore warning on shift operator promotion.
173 } 173 }
174 174
175 public_configs = [ ":common_audio_config" ] 175 public_configs = [ ":common_audio_config" ]
176 176
177 if (is_clang) { 177 if (!build_with_chromium && is_clang) {
178 # Suppress warnings from Chrome's Clang plugins. 178 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
179 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
180 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 179 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
181 } 180 }
182 181
183 if (current_cpu == "x86" || current_cpu == "x64") { 182 if (current_cpu == "x86" || current_cpu == "x64") {
184 deps += [ ":common_audio_sse2" ] 183 deps += [ ":common_audio_sse2" ]
185 } 184 }
186 } 185 }
187 186
188 if (current_cpu == "x86" || current_cpu == "x64") { 187 if (current_cpu == "x86" || current_cpu == "x64") {
189 rtc_static_library("common_audio_sse2") { 188 rtc_static_library("common_audio_sse2") {
190 sources = [ 189 sources = [
191 "fir_filter_sse.cc", 190 "fir_filter_sse.cc",
192 "resampler/sinc_resampler_sse.cc", 191 "resampler/sinc_resampler_sse.cc",
193 ] 192 ]
194 193
195 if (is_posix) { 194 if (is_posix) {
196 cflags = [ "-msse2" ] 195 cflags = [ "-msse2" ]
197 } 196 }
198 197
199 if (is_clang) { 198 if (!build_with_chromium && is_clang) {
200 # Suppress warnings from Chrome's Clang plugins. 199 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
201 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
202 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 200 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
203 } 201 }
204 } 202 }
205 } 203 }
206 204
207 if (rtc_build_with_neon) { 205 if (rtc_build_with_neon) {
208 rtc_static_library("common_audio_neon") { 206 rtc_static_library("common_audio_neon") {
209 sources = [ 207 sources = [
210 "fir_filter_neon.cc", 208 "fir_filter_neon.cc",
211 "resampler/sinc_resampler_neon.cc", 209 "resampler/sinc_resampler_neon.cc",
(...skipping 12 matching lines...) Expand all
224 222
225 # Disable LTO on NEON targets due to compiler bug. 223 # Disable LTO on NEON targets due to compiler bug.
226 # TODO(fdegans): Enable this. See crbug.com/408997. 224 # TODO(fdegans): Enable this. See crbug.com/408997.
227 if (rtc_use_lto) { 225 if (rtc_use_lto) {
228 cflags -= [ 226 cflags -= [
229 "-flto", 227 "-flto",
230 "-ffat-lto-objects", 228 "-ffat-lto-objects",
231 ] 229 ]
232 } 230 }
233 231
234 if (is_clang) { 232 if (!build_with_chromium && is_clang) {
235 # Suppress warnings from Chrome's Clang plugins. 233 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
236 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
237 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 234 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
238 } 235 }
239 } 236 }
240 } 237 }
241 238
242 if (rtc_include_tests) { 239 if (rtc_include_tests) {
243 rtc_test("common_audio_unittests") { 240 rtc_test("common_audio_unittests") {
244 testonly = true 241 testonly = true
245 242
246 sources = [ 243 sources = [
(...skipping 27 matching lines...) Expand all
274 271
275 # Does not compile on iOS for arm: webrtc:5544. 272 # Does not compile on iOS for arm: webrtc:5544.
276 if (!is_ios || target_cpu != "arm") { 273 if (!is_ios || target_cpu != "arm") {
277 sources += [ "resampler/sinc_resampler_unittest.cc" ] 274 sources += [ "resampler/sinc_resampler_unittest.cc" ]
278 } 275 }
279 276
280 if (rtc_use_openmax_dl) { 277 if (rtc_use_openmax_dl) {
281 defines = [ "RTC_USE_OPENMAX_DL" ] 278 defines = [ "RTC_USE_OPENMAX_DL" ]
282 } 279 }
283 280
284 if (is_clang) { 281 if (!build_with_chromium && is_clang) {
285 # Suppress warnings from the Chromium Clang plugin. 282 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
286 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
287 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 283 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
288 } 284 }
289 285
290 deps = [ 286 deps = [
291 ":common_audio", 287 ":common_audio",
292 "../test:test_support_main", 288 "../test:test_support_main",
293 "//testing/gmock", 289 "//testing/gmock",
294 "//testing/gtest", 290 "//testing/gtest",
295 ] 291 ]
296 292
297 if (is_android) { 293 if (is_android) {
298 deps += [ "//testing/android/native_test:native_test_support" ] 294 deps += [ "//testing/android/native_test:native_test_support" ]
299 295
300 shard_timeout = 900 296 shard_timeout = 900
301 } 297 }
302 } 298 }
303 } 299 }
OLDNEW
« no previous file with comments | « webrtc/call/BUILD.gn ('k') | webrtc/common_video/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698