GN: Exclude suppressions of Chromium Clang warnings for Chromium builds.

webrtc/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 # TODO(kjellander): Rebase this to webrtc/build/common.gypi changes after r6330.
 
@@ skipping 284 matching lines @@
 rtc_static_library("webrtc_common") {
   sources = [
     "common_types.cc",
     "common_types.h",
     "config.cc",
     "config.h",
     "typedefs.h",
     "voice_engine_configurations.h",
   ]
 
-  if (is_clang && !is_nacl) {
-    # Suppress warnings from Chrome's Clang plugins.
-    # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+  if (!build_with_chromium && is_clang) {
+    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 }
 
 if (use_libfuzzer || use_drfuzz || use_afl) {
   # This target is only here for gn to discover fuzzer build targets under
   # webrtc/test/fuzzers/.
   group("webrtc_fuzzers_dummy") {
     testonly = true
     deps = [
@@ skipping 157 matching lines @@
         "p2p/quic/quicconnectionhelper_unittest.cc",
         "p2p/quic/quicsession_unittest.cc",
         "p2p/quic/quictransport_unittest.cc",
         "p2p/quic/quictransportchannel_unittest.cc",
         "p2p/quic/reliablequicstream_unittest.cc",
       ]
     }
 
     configs += [ ":rtc_unittests_config" ]
 
-    if (is_clang) {
-      # Suppress warnings from the Chromium Clang plugin.
-      # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+    if (!build_with_chromium && is_clang) {
+      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
 
     deps = [
       "base:rtc_base",
       "base:rtc_base_tests_utils",
       "base:rtc_task_queue",
       "p2p:libstunprober",
       "p2p:rtc_p2p",
       "//testing/gmock",
@@ skipping 29 matching lines @@
       # |-ObjC| flag needed to make sure category method implementations
       # are included:
       # https://developer.apple.com/library/mac/qa/qa1490/_index.html
       ldflags = [ "-ObjC" ]
     }
   }
 
   rtc_test("xmllite_xmpp_unittests") {
     configs += [ ":rtc_unittests_config" ]
 
-    if (is_clang) {
-      # Suppress warnings from the Chromium Clang plugin.
-      # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+    if (!build_with_chromium && is_clang) {
+      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
 
     deps = [
       "base:rtc_base_tests_utils",
       "libjingle/xmllite:rtc_xmllite",
       "libjingle/xmpp:rtc_xmpp",
       "//testing/gtest",
     ]
 
@@ skipping 42 matching lines @@
     testonly = true
     deps = [
       "audio:audio_tests",
       "call:call_tests",
       "modules/video_capture",
       "test:test_common",
       "test:test_main",
       "video:video_tests",
     ]
     data = video_engine_tests_resources
-    if (is_clang) {
-      # Suppress warnings from the Chromium Clang plugin.
-      # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+    if (!build_with_chromium && is_clang) {
+      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
     if (is_android) {
       deps += [ "//testing/android/native_test:native_test_native_code" ]
       shard_timeout = 900
     }
 
     if (is_ios) {
       deps += [ ":video_engine_tests_bundle_data" ]
     }
   }
 
   rtc_source_set("video_quality_test") {
     testonly = true
     sources = [
       "video/video_quality_test.cc",
       "video/video_quality_test.h",
     ]
     deps = [
       ":webrtc",
       "system_wrappers",
       "//testing/gtest",
     ]
     if (!is_android) {
       deps += [ "modules/video_capture:video_capture_internal_impl" ]
     }
-    if (is_clang) {
-      # Suppress warnings from the Chromium Clang plugin.
-      # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+    if (!build_with_chromium && is_clang) {
+      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 
   webrtc_perf_tests_resources = [
     "//resources/audio_coding/speech_mono_16kHz.pcm",
     "//resources/audio_coding/testfile32kHz.pcm",
     "//resources/ConferenceMotion_1280_720_50.yuv",
     "//resources/difficult_photo_1850_1110.yuv",
     "//resources/foreman_cif.yuv",
@@ skipping 40 matching lines @@
     deps = [
       ":video_quality_test",
       "system_wrappers:metrics_default",
       "test:field_trial",
       "test:test_common",
       "test:test_renderer",
       "//testing/gmock",
       "//testing/gtest",
       "//third_party/gflags",
     ]
-    if (is_clang && !is_nacl) {
-      # Suppress warnings from Chrome's Clang plugins.
-      # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+    if (!build_with_chromium && is_clang) {
+      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 
   rtc_test("webrtc_perf_tests") {
     testonly = true
     configs += [ ":rtc_unittests_config" ]
 
     sources = [
       "call/call_perf_tests.cc",
@@ skipping 28 matching lines @@
     }
 
     data = webrtc_perf_tests_resources
     if (is_android) {
       deps += [ "//testing/android/native_test:native_test_native_code" ]
       shard_timeout = 2700
     }
     if (is_ios) {
       deps += [ ":webrtc_perf_tests_bundle_data" ]
     }
-    if (is_clang) {
-      # Suppress warnings from the Chromium Clang plugin.
-      # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+    if (!build_with_chromium && is_clang) {
+      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 
   rtc_test("webrtc_nonparallel_tests") {
     testonly = true
     configs += [ ":rtc_unittests_config" ]
     sources = [
       "base/nullsocketserver_unittest.cc",
       "base/physicalsocketserver_unittest.cc",
       "base/socket_unittest.cc",
       "base/socket_unittest.h",
       "base/socketaddress_unittest.cc",
       "base/virtualsocket_unittest.cc",
     ]
     deps = [
       "base:rtc_base",
       "base:rtc_base_tests_utils",
       "//testing/gtest",
     ]
     if (is_win) {
       sources += [ "base/win32socketserver_unittest.cc" ]
     }
     if (is_android) {
       deps += [ "//testing/android/native_test:native_test_support" ]
       shard_timeout = 900
     }
 
-    if (is_clang) {
-      # Suppress warnings from the Chromium Clang plugin.
-      # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+    if (!build_with_chromium && is_clang) {
+      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 
   if (is_android) {
     junit_binary("android_junit_tests") {
       java_files = [
         "androidjunit/src/org/webrtc/CameraEnumerationTest.java",
         "examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java",
         "examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java",
       ]
 
       deps = [
         "//base:base_java_test_support",
         "//webrtc/api:libjingle_peerconnection_java",
         "//webrtc/api:libjingle_peerconnection_jni",
         "//webrtc/examples:AppRTCMobile_javalib",
       ]
     }
   }
 }