Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: webrtc/media/BUILD.gn

Issue 2408133008: GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/logging/BUILD.gn ('k') | webrtc/modules/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("//build/config/linux/pkg_config.gni") 9 import("//build/config/linux/pkg_config.gni")
10 import("../build/webrtc.gni") 10 import("../build/webrtc.gni")
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 "engine/webrtcvideoframe.h", 106 "engine/webrtcvideoframe.h",
107 "engine/webrtcvoe.h", 107 "engine/webrtcvoe.h",
108 "engine/webrtcvoiceengine.cc", 108 "engine/webrtcvoiceengine.cc",
109 "engine/webrtcvoiceengine.h", 109 "engine/webrtcvoiceengine.h",
110 "sctp/sctpdataengine.cc", 110 "sctp/sctpdataengine.cc",
111 "sctp/sctpdataengine.h", 111 "sctp/sctpdataengine.h",
112 ] 112 ]
113 113
114 configs += [ ":rtc_media_warnings_config" ] 114 configs += [ ":rtc_media_warnings_config" ]
115 115
116 if (is_clang) { 116 if (!build_with_chromium && is_clang) {
117 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 117 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
118 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 118 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
119 } 119 }
120 120
121 if (is_win) { 121 if (is_win) {
122 cflags = [ 122 cflags = [
123 "/wd4245", # conversion from "int" to "size_t", signed/unsigned mismatch. 123 "/wd4245", # conversion from "int" to "size_t", signed/unsigned mismatch.
124 "/wd4267", # conversion from "size_t" to "int", possible loss of data. 124 "/wd4267", # conversion from "size_t" to "int", possible loss of data.
125 "/wd4389", # signed/unsigned mismatch. 125 "/wd4389", # signed/unsigned mismatch.
126 ] 126 ]
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 configs += [ ":rtc_unittest_main_config" ] 229 configs += [ ":rtc_unittest_main_config" ]
230 230
231 if (rtc_build_libyuv) { 231 if (rtc_build_libyuv) {
232 deps += [ "$rtc_libyuv_dir" ] 232 deps += [ "$rtc_libyuv_dir" ]
233 public_deps += [ "$rtc_libyuv_dir" ] 233 public_deps += [ "$rtc_libyuv_dir" ]
234 } else { 234 } else {
235 # Need to add a directory normally exported by libyuv. 235 # Need to add a directory normally exported by libyuv.
236 include_dirs += [ "$rtc_libyuv_dir/include" ] 236 include_dirs += [ "$rtc_libyuv_dir/include" ]
237 } 237 }
238 238
239 if (is_clang) { 239 if (!build_with_chromium && is_clang) {
240 # Suppress warnings from the Chromium Clang plugin. 240 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
241 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
242 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 241 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
243 } 242 }
244 243
245 deps += [ 244 deps += [
246 "../base:rtc_base_tests_utils", 245 "../base:rtc_base_tests_utils",
247 "//testing/gtest", 246 "//testing/gtest",
248 ] 247 ]
249 public_deps += [ "//testing/gmock" ] 248 public_deps += [ "//testing/gmock" ]
250 } 249 }
251 250
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 defines += [ "WEBRTC_USE_H264" ] 323 defines += [ "WEBRTC_USE_H264" ]
325 } 324 }
326 if (is_win) { 325 if (is_win) {
327 cflags = [ 326 cflags = [
328 "/wd4245", # conversion from int to size_t, signed/unsigned mismatch. 327 "/wd4245", # conversion from int to size_t, signed/unsigned mismatch.
329 "/wd4373", # virtual function override. 328 "/wd4373", # virtual function override.
330 "/wd4389", # signed/unsigned mismatch. 329 "/wd4389", # signed/unsigned mismatch.
331 ] 330 ]
332 } 331 }
333 332
334 if (is_clang) { 333 if (!build_with_chromium && is_clang) {
335 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
336 suppressed_configs += [ 334 suppressed_configs += [
337 "//build/config/clang:extra_warnings", 335 "//build/config/clang:extra_warnings",
336
337 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163) .
338 "//build/config/clang:find_bad_constructs", 338 "//build/config/clang:find_bad_constructs",
339 ] 339 ]
340 } 340 }
341 341
342 data = rtc_media_unittests_resources 342 data = rtc_media_unittests_resources
343 343
344 if (is_android) { 344 if (is_android) {
345 deps += [ "//testing/android/native_test:native_test_support" ] 345 deps += [ "//testing/android/native_test:native_test_support" ]
346 shard_timeout = 900 346 shard_timeout = 900
347 } 347 }
348 348
349 if (is_ios) { 349 if (is_ios) {
350 deps += [ ":rtc_media_unittests_bundle_data" ] 350 deps += [ ":rtc_media_unittests_bundle_data" ]
351 } 351 }
352 352
353 deps += [ 353 deps += [
354 # TODO(kjellander): Move as part of work in bugs.webrtc.org/4243. 354 # TODO(kjellander): Move as part of work in bugs.webrtc.org/4243.
355 ":rtc_media", 355 ":rtc_media",
356 ":rtc_unittest_main", 356 ":rtc_unittest_main",
357 "../audio", 357 "../audio",
358 "../base:rtc_base_tests_utils", 358 "../base:rtc_base_tests_utils",
359 "../system_wrappers:metrics_default", 359 "../system_wrappers:metrics_default",
360 ] 360 ]
361 } 361 }
362 } 362 }
OLDNEW
« no previous file with comments | « webrtc/logging/BUILD.gn ('k') | webrtc/modules/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698