Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: webrtc/modules/video_capture/BUILD.gn

Issue 2408133008: GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/utility/BUILD.gn ('k') | webrtc/modules/video_coding/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../../build/webrtc.gni") 9 import("../../build/webrtc.gni")
10 10
(...skipping 15 matching lines...) Expand all
26 "video_capture_impl.h", 26 "video_capture_impl.h",
27 ] 27 ]
28 28
29 deps = [ 29 deps = [
30 "../..:webrtc_common", 30 "../..:webrtc_common",
31 "../../common_video", 31 "../../common_video",
32 "../../system_wrappers", 32 "../../system_wrappers",
33 "../utility", 33 "../utility",
34 ] 34 ]
35 35
36 if (is_clang) { 36 if (!build_with_chromium && is_clang) {
37 # Suppress warnings from Chrome's Clang plugins. 37 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
38 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
39 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 38 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
40 } 39 }
41 } 40 }
42 41
43 rtc_static_library("video_capture") { 42 rtc_static_library("video_capture") {
44 sources = [ 43 sources = [
45 "external/device_info_external.cc", 44 "external/device_info_external.cc",
46 "external/video_capture_external.cc", 45 "external/video_capture_external.cc",
47 ] 46 ]
48 47
49 deps = [ 48 deps = [
50 ":video_capture_module", 49 ":video_capture_module",
51 "../../system_wrappers", 50 "../../system_wrappers",
52 ] 51 ]
53 52
54 if (is_clang) { 53 if (!build_with_chromium && is_clang) {
55 # Suppress warnings from Chrome's Clang plugins. 54 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
56 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
57 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 55 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
58 } 56 }
59 } 57 }
60 58
61 if (!build_with_chromium) { 59 if (!build_with_chromium) {
62 config("video_capture_internal_impl_config") { 60 config("video_capture_internal_impl_config") {
63 if (is_ios || is_mac) { 61 if (is_ios || is_mac) {
64 libs = [ 62 libs = [
65 "AVFoundation.framework", 63 "AVFoundation.framework",
66 "CoreMedia.framework", 64 "CoreMedia.framework",
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 140
143 # To avoid warnings for deprecated videoMinFrameDuration and 141 # To avoid warnings for deprecated videoMinFrameDuration and
144 # videoMaxFrameDuration properties in iOS 7.0. 142 # videoMaxFrameDuration properties in iOS 7.0.
145 # See webrtc:3705 for more details. 143 # See webrtc:3705 for more details.
146 "-Wno-deprecated-declarations", 144 "-Wno-deprecated-declarations",
147 ] 145 ]
148 } 146 }
149 147
150 all_dependent_configs = [ ":video_capture_internal_impl_config" ] 148 all_dependent_configs = [ ":video_capture_internal_impl_config" ]
151 149
152 if (is_clang) { 150 if (!build_with_chromium && is_clang) {
153 # Suppress warnings from Chrome's Clang plugins. 151 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
154 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
155 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 152 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
156 } 153 }
157 } 154 }
158 155
159 if (!is_android && rtc_include_tests) { 156 if (!is_android && rtc_include_tests) {
160 rtc_test("video_capture_tests") { 157 rtc_test("video_capture_tests") {
161 sources = [ 158 sources = [
162 "test/video_capture_unittest.cc", 159 "test/video_capture_unittest.cc",
163 ] 160 ]
164 161
(...skipping 20 matching lines...) Expand all
185 deps = [ 182 deps = [
186 ":video_capture_internal_impl", 183 ":video_capture_internal_impl",
187 ":video_capture_module", 184 ":video_capture_module",
188 "../../system_wrappers:system_wrappers_default", 185 "../../system_wrappers:system_wrappers_default",
189 "../../test:video_test_common", 186 "../../test:video_test_common",
190 "../utility", 187 "../utility",
191 "//testing/gtest", 188 "//testing/gtest",
192 ] 189 ]
193 deps += [ "//webrtc/test:test_support_main" ] 190 deps += [ "//webrtc/test:test_support_main" ]
194 191
195 if (is_clang) { 192 if (!build_with_chromium && is_clang) {
196 # Suppress warnings from Chrome's Clang plugins. 193 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163) .
197 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
198 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 194 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
199 } 195 }
200 } 196 }
201 } 197 }
202 } 198 }
OLDNEW
« no previous file with comments | « webrtc/modules/utility/BUILD.gn ('k') | webrtc/modules/video_coding/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698