Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: webrtc/sdk/BUILD.gn

Issue 2408133008: GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/pc/BUILD.gn ('k') | webrtc/stats/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/BUILD.gn
diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn
index f7c35ff883485b11dc9a08003edef9502fbd142c..755390c38c2e0a935513c3096dbe9ebd5a0a9d65 100644
--- a/webrtc/sdk/BUILD.gn
+++ b/webrtc/sdk/BUILD.gn
@@ -194,9 +194,8 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
public_configs = [ ":rtc_sdk_common_objc_config" ]
- if (is_clang) {
- # Suppress warnings from the Chromium Clang plugins.
- # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+ if (!build_with_chromium && is_clang) {
+ # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
@@ -287,9 +286,8 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
public_configs = [ ":rtc_sdk_common_objc_config" ]
- if (is_clang) {
- # Suppress warnings from the Chromium Clang plugins.
- # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+ if (!build_with_chromium && is_clang) {
+ # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163)
configs -= [ "//build/config/clang:find_bad_constructs" ]
}
}
@@ -331,9 +329,8 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
public_configs = [ ":rtc_sdk_common_objc_config" ]
- if (is_clang) {
- # Suppress warnings from the Chromium Clang plugins.
- # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+ if (!build_with_chromium && is_clang) {
+ # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163)
configs -= [ "//build/config/clang:find_bad_constructs" ]
}
}
« no previous file with comments | « webrtc/pc/BUILD.gn ('k') | webrtc/stats/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698