Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: webrtc/modules/remote_bitrate_estimator/BUILD.gn

Issue 2408133008: GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/pacing/BUILD.gn ('k') | webrtc/modules/rtp_rtcp/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../../build/webrtc.gni") 9 import("../../build/webrtc.gni")
10 10
(...skipping 21 matching lines...) Expand all
32 "test/bwe_test_logging.h", 32 "test/bwe_test_logging.h",
33 ] 33 ]
34 34
35 if (rtc_enable_bwe_test_logging) { 35 if (rtc_enable_bwe_test_logging) {
36 defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=1" ] 36 defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=1" ]
37 sources += [ "test/bwe_test_logging.cc" ] 37 sources += [ "test/bwe_test_logging.cc" ]
38 } else { 38 } else {
39 defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ] 39 defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ]
40 } 40 }
41 41
42 if (is_clang) { 42 if (!build_with_chromium && is_clang) {
43 # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163). 43 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
44 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 44 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
45 } 45 }
46 46
47 deps = [ 47 deps = [
48 "../..:webrtc_common", 48 "../..:webrtc_common",
49 "../../base:rtc_base_approved", 49 "../../base:rtc_base_approved",
50 "../../system_wrappers", 50 "../../system_wrappers",
51 ] 51 ]
52 } 52 }
53 53
(...skipping 28 matching lines...) Expand all
82 "test/packet_sender.cc", 82 "test/packet_sender.cc",
83 "test/packet_sender.h", 83 "test/packet_sender.h",
84 ] 84 ]
85 85
86 if (rtc_enable_bwe_test_logging) { 86 if (rtc_enable_bwe_test_logging) {
87 defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=1" ] 87 defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=1" ]
88 } else { 88 } else {
89 defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ] 89 defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ]
90 } 90 }
91 91
92 if (is_clang) { 92 if (!build_with_chromium && is_clang) {
93 # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163). 93 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
94 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 94 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
95 } 95 }
96 96
97 if (is_win) { 97 if (is_win) {
98 cflags = [ 98 cflags = [
99 # TODO(kjellander): Bug 261: fix this warning. 99 # TODO(kjellander): Bug 261: fix this warning.
100 "/wd4373", # virtual function override. 100 "/wd4373", # virtual function override.
101 ] 101 ]
102 } 102 }
103 103
104 deps = [ 104 deps = [
105 "../../test:test_support", 105 "../../test:test_support",
106 "../pacing", 106 "../pacing",
107 "//testing/gmock", 107 "//testing/gmock",
108 "//testing/gtest", 108 "//testing/gtest",
109 ] 109 ]
110 } 110 }
111 } 111 }
OLDNEW
« no previous file with comments | « webrtc/modules/pacing/BUILD.gn ('k') | webrtc/modules/rtp_rtcp/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698