webrtc/base/BUILD.gn - Issue 2408133008: GN: Exclude suppressions of Chromium Clang warnings for Chromium builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/BUILD.gn

Issue 2408133008: GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/base/BUILD.gn

diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn

index ea97be08e752c0a7d715d19f6d8bdb068fd921fb..402691fbe06c4dcf5f1b0915590eeb063b5beabe 100644

--- a/webrtc/base/BUILD.gn

+++ b/webrtc/base/BUILD.gn

@@ -786,7 +786,7 @@ if (rtc_include_tests) {

"//testing/gtest",

]

- if (is_clang) {

+ if (!build_with_chromium && is_clang) {

# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).

suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]

}

« no previous file with comments | « webrtc/audio/BUILD.gn ('k') | webrtc/call/BUILD.gn » ('j') | no next file with comments »