Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: webrtc/pc/BUILD.gn

Issue 2408133008: GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/p2p/BUILD.gn ('k') | webrtc/sdk/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../build/webrtc.gni") 9 import("../build/webrtc.gni")
10 10
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 "externalhmac.cc", 57 "externalhmac.cc",
58 "externalhmac.h", 58 "externalhmac.h",
59 ] 59 ]
60 } 60 }
61 if (rtc_build_libsrtp) { 61 if (rtc_build_libsrtp) {
62 deps += [ "//third_party/libsrtp" ] 62 deps += [ "//third_party/libsrtp" ]
63 } 63 }
64 64
65 public_configs = [ ":rtc_pc_config" ] 65 public_configs = [ ":rtc_pc_config" ]
66 66
67 if (is_clang) { 67 if (!build_with_chromium && is_clang) {
68 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 68 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
69 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 69 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
70 } 70 }
71 } 71 }
72 72
73 if (rtc_include_tests) { 73 if (rtc_include_tests) {
74 config("rtc_pc_unittests_config") { 74 config("rtc_pc_unittests_config") {
75 # GN orders flags on a target before flags from configs. The default config 75 # GN orders flags on a target before flags from configs. The default config
76 # adds -Wall, and this flag have to be after -Wall -- so they need to 76 # adds -Wall, and this flag have to be after -Wall -- so they need to
77 # come from a config and can't be on the target directly. 77 # come from a config and can't be on the target directly.
(...skipping 12 matching lines...) Expand all
90 "currentspeakermonitor_unittest.cc", 90 "currentspeakermonitor_unittest.cc",
91 "mediasession_unittest.cc", 91 "mediasession_unittest.cc",
92 "rtcpmuxfilter_unittest.cc", 92 "rtcpmuxfilter_unittest.cc",
93 "srtpfilter_unittest.cc", 93 "srtpfilter_unittest.cc",
94 ] 94 ]
95 95
96 include_dirs = [ "//third_party/libsrtp/srtp" ] 96 include_dirs = [ "//third_party/libsrtp/srtp" ]
97 97
98 configs += [ ":rtc_pc_unittests_config" ] 98 configs += [ ":rtc_pc_unittests_config" ]
99 99
100 if (is_clang) { 100 if (!build_with_chromium && is_clang) {
101 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 101 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
102 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 102 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
103 } 103 }
104 104
105 if (is_win) { 105 if (is_win) {
106 libs = [ "strmiids.lib" ] 106 libs = [ "strmiids.lib" ]
107 } 107 }
108 108
109 deps = [ 109 deps = [
110 ":rtc_pc", 110 ":rtc_pc",
111 "../api:libjingle_peerconnection", 111 "../api:libjingle_peerconnection",
112 "../base:rtc_base_tests_utils", 112 "../base:rtc_base_tests_utils",
113 "../media:rtc_unittest_main", 113 "../media:rtc_unittest_main",
114 "../system_wrappers:metrics_default", 114 "../system_wrappers:metrics_default",
115 ] 115 ]
116 116
117 if (rtc_build_libsrtp) { 117 if (rtc_build_libsrtp) {
118 deps += [ "//third_party/libsrtp" ] 118 deps += [ "//third_party/libsrtp" ]
119 } 119 }
120 120
121 if (is_android) { 121 if (is_android) {
122 deps += [ "//testing/android/native_test:native_test_support" ] 122 deps += [ "//testing/android/native_test:native_test_support" ]
123 } 123 }
124 } 124 }
125 } 125 }
OLDNEW
« no previous file with comments | « webrtc/p2p/BUILD.gn ('k') | webrtc/sdk/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698