| Index: webrtc/tools/BUILD.gn
|
| diff --git a/webrtc/tools/BUILD.gn b/webrtc/tools/BUILD.gn
|
| index 1ba2018a351888d7bc714a3f3ea2afde2727eabf..b94a10fab580eed04a6e5000b3f3530316f63d10 100644
|
| --- a/webrtc/tools/BUILD.gn
|
| +++ b/webrtc/tools/BUILD.gn
|
| @@ -94,9 +94,8 @@ rtc_static_library("frame_editing_lib") {
|
| # TODO(jschuh): Bug 1348: fix this warning.
|
| configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from the Chromium Clang plugin.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -124,9 +123,8 @@ if (rtc_include_internal_audio_device) {
|
| "force_mic_volume_max/force_mic_volume_max.cc",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from the Chromium Clang plugin.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -157,9 +155,8 @@ if (rtc_enable_protobuf) {
|
| "event_log_visualizer/plot_python.cc",
|
| "event_log_visualizer/plot_python.h",
|
| ]
|
| - if (is_clang && !is_nacl) {
|
| - # Suppress warnings from the Chromium Clang plugin.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
| defines = [ "ENABLE_RTC_EVENT_LOG" ]
|
| @@ -187,9 +184,8 @@ if (rtc_include_tests) {
|
| "event_log_visualizer/main.cc",
|
| ]
|
|
|
| - if (is_clang && !is_nacl) {
|
| - # Suppress warnings from the Chromium Clang plugin.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -207,9 +203,8 @@ if (rtc_include_tests) {
|
| "agc/activity_metric.cc",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from the Chromium Clang plugin.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -246,9 +241,8 @@ if (rtc_include_tests) {
|
| # TODO(jschuh): Bug 1348: fix this warning.
|
| configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from the Chromium Clang plugin.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
|
|