Audit of kConstants missing the const qualifier

Audit of kConstants missing the const qualifier

Found via supersize query:
size_info.symbols.WhereFullNameMatches(r'\bk[A-Z]').WhereInSection('d')

This moves 90 symbols from .data -> .data.rel.ro (5.50kb)

BUG=chromium:747064
Review-Url: https://codereview.webrtc.org/2986163002
Cr-Commit-Position: refs/heads/master@{#19274}
Committed: https://chromium.googlesource.com/external/webrtc/+/26622d3ff8dcbddd6027a148a4be42d7c0de60e1

[agrieve, 2017-07-28 19:31:27]

Description was changed from

==========
Audit of kConstants missing the const qualifier

Found via supersize query:
size_info.symbols.WhereFullNameMatches(r'\bk[A-Z]').WhereInSection('d')

This moves 90 symbols from .data -> .data.rel.ro (5.50kb)

BUG=chromium:747064
==========

to

==========
Audit of kConstants missing the const qualifier

Found via supersize query:
size_info.symbols.WhereFullNameMatches(r'\bk[A-Z]').WhereInSection('d')

This moves 90 symbols from .data -> .data.rel.ro (5.50kb)

BUG=chromium:747064
==========

[agrieve, 2017-07-28 19:31:27]

agrieve@chromium.org changed reviewers:
+ kwiberg@webrtc.org

[agrieve, 2017-07-28 19:33:00]

On 2017/07/28 19:31:27, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:kwiberg@webrtc.org

Presubmit gave the warning below. Let me know if you think it warrants not
adding const to things.


** Presubmit Messages **

You seem to be changing native API header files. Please make sure that you:
  1. Make compatible changes that don't break existing clients. Usually
     this is done by keeping the existing method signatures unchanged.
  2. Mark the old stuff as deprecated (see RTC_DEPRECATED macro).
  3. Create a timeline and plan for when the deprecated stuff will be
     removed. (The amount of time we give users to change their code
     should be informed by how much work it is for them. If they just
     need to replace one name with another or something equally
     simple, 1-2 weeks might be good; if they need to do serious work,
     up to 3 months may be called for.)
  4. Update/inform existing downstream code owners to stop using the
     deprecated stuff. (Send announcements to
     discuss-webrtc@googlegroups.com and webrtc-users@google.com.)
  5. Remove the deprecated stuff, once the agreed-upon amount of time
     has passed.
Related files:

  webrtc/config.h \
  webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h \
  webrtc/modules/rtp_rtcp/source/fec_private_tables_bursty.h \
  webrtc/modules/rtp_rtcp/source/fec_private_tables_random.h \
  webrtc/modules/rtp_rtcp/source/forward_error_correction_internal.h \
  webrtc/rtc_base/sslroots.h

[agrieve, 2017-07-28 19:33:05]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-28 19:33:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-28 20:54:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-28 20:54:03]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-07-31 05:58:30]

lgtm

Go for it! If you're feeling careful you might split it up into pieces so that
you can revert just the parts of it that fails, but it doesn't look like any
sane client should be affected by this change.

https://codereview.webrtc.org/2986163002/diff/1/webrtc/modules/audio_processi...
File
webrtc/modules/audio_processing/level_controller/noise_spectrum_estimator.cc
(right):

https://codereview.webrtc.org/2986163002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/level_controller/noise_spectrum_estimator.cc:22:
const float kMinNoisePower = 100.f;
constexpr?

[agrieve, 2017-08-08 17:21:17]

On 2017/07/31 05:58:30, kwiberg-webrtc wrote:
> lgtm
> 
> Go for it! If you're feeling careful you might split it up into pieces so that
> you can revert just the parts of it that fails, but it doesn't look like any
> sane client should be affected by this change.
> 
>
https://codereview.webrtc.org/2986163002/diff/1/webrtc/modules/audio_processi...
> File
> webrtc/modules/audio_processing/level_controller/noise_spectrum_estimator.cc
> (right):
> 
>
https://codereview.webrtc.org/2986163002/diff/1/webrtc/modules/audio_processi...
>
webrtc/modules/audio_processing/level_controller/noise_spectrum_estimator.cc:22:
> const float kMinNoisePower = 100.f;
> constexpr?

Thanks! I've already tested that Chrome compiles with these changes, so will
give it a go now rather than splitting.

[agrieve, 2017-08-08 17:21:28]

https://codereview.webrtc.org/2986163002/diff/1/webrtc/modules/audio_processi...
File
webrtc/modules/audio_processing/level_controller/noise_spectrum_estimator.cc
(right):

https://codereview.webrtc.org/2986163002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/level_controller/noise_spectrum_estimator.cc:22:
const float kMinNoisePower = 100.f;
On 2017/07/31 05:58:29, kwiberg-webrtc wrote:
> constexpr?

Done.

[agrieve, 2017-08-08 17:21:32]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2017-08-08 17:21:33]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2986163002/#ps20001 (title:
"rebase + constexpr")

[commit-bot: I haz the power, 2017-08-08 17:21:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-08 17:48:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1502212892387760,
"parent_rev": "f50fda9534563885ab080ae18c2540a0f5b930bc", "commit_rev":
"26622d3ff8dcbddd6027a148a4be42d7c0de60e1"}

[commit-bot: I haz the power, 2017-08-08 17:48:23]

Description was changed from

==========
Audit of kConstants missing the const qualifier

Found via supersize query:
size_info.symbols.WhereFullNameMatches(r'\bk[A-Z]').WhereInSection('d')

This moves 90 symbols from .data -> .data.rel.ro (5.50kb)

BUG=chromium:747064
==========

to

==========
Audit of kConstants missing the const qualifier

Found via supersize query:
size_info.symbols.WhereFullNameMatches(r'\bk[A-Z]').WhereInSection('d')

This moves 90 symbols from .data -> .data.rel.ro (5.50kb)

BUG=chromium:747064

Review-Url: https://codereview.webrtc.org/2986163002
Cr-Commit-Position: refs/heads/master@{#19274}
Committed:
https://chromium.googlesource.com/external/webrtc/+/26622d3ff8dcbddd6027a148a...
==========

[commit-bot: I haz the power, 2017-08-08 17:48:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/26622d3ff8dcbddd6027a148a...