Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: webrtc/config.cc

Issue 2986163002: Audit of kConstants missing the const qualifier (Closed)
Patch Set: rebase + constexpr Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/config.h ('k') | webrtc/media/engine/webrtcmediaengine.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include "webrtc/config.h" 10 #include "webrtc/config.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 std::stringstream ss; 42 std::stringstream ss;
43 ss << "{uri: " << uri; 43 ss << "{uri: " << uri;
44 ss << ", id: " << id; 44 ss << ", id: " << id;
45 if (encrypt) { 45 if (encrypt) {
46 ss << ", encrypt"; 46 ss << ", encrypt";
47 } 47 }
48 ss << '}'; 48 ss << '}';
49 return ss.str(); 49 return ss.str();
50 } 50 }
51 51
52 const char* RtpExtension::kAudioLevelUri = 52 const char RtpExtension::kAudioLevelUri[] =
53 "urn:ietf:params:rtp-hdrext:ssrc-audio-level"; 53 "urn:ietf:params:rtp-hdrext:ssrc-audio-level";
54 const int RtpExtension::kAudioLevelDefaultId = 1; 54 const int RtpExtension::kAudioLevelDefaultId = 1;
55 55
56 const char* RtpExtension::kTimestampOffsetUri = 56 const char RtpExtension::kTimestampOffsetUri[] =
57 "urn:ietf:params:rtp-hdrext:toffset"; 57 "urn:ietf:params:rtp-hdrext:toffset";
58 const int RtpExtension::kTimestampOffsetDefaultId = 2; 58 const int RtpExtension::kTimestampOffsetDefaultId = 2;
59 59
60 const char* RtpExtension::kAbsSendTimeUri = 60 const char RtpExtension::kAbsSendTimeUri[] =
61 "http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time"; 61 "http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time";
62 const int RtpExtension::kAbsSendTimeDefaultId = 3; 62 const int RtpExtension::kAbsSendTimeDefaultId = 3;
63 63
64 const char* RtpExtension::kVideoRotationUri = "urn:3gpp:video-orientation"; 64 const char RtpExtension::kVideoRotationUri[] = "urn:3gpp:video-orientation";
65 const int RtpExtension::kVideoRotationDefaultId = 4; 65 const int RtpExtension::kVideoRotationDefaultId = 4;
66 66
67 const char* RtpExtension::kTransportSequenceNumberUri = 67 const char RtpExtension::kTransportSequenceNumberUri[] =
68 "http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01"; 68 "http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01";
69 const int RtpExtension::kTransportSequenceNumberDefaultId = 5; 69 const int RtpExtension::kTransportSequenceNumberDefaultId = 5;
70 70
71 // This extension allows applications to adaptively limit the playout delay 71 // This extension allows applications to adaptively limit the playout delay
72 // on frames as per the current needs. For example, a gaming application 72 // on frames as per the current needs. For example, a gaming application
73 // has very different needs on end-to-end delay compared to a video-conference 73 // has very different needs on end-to-end delay compared to a video-conference
74 // application. 74 // application.
75 const char* RtpExtension::kPlayoutDelayUri = 75 const char RtpExtension::kPlayoutDelayUri[] =
76 "http://www.webrtc.org/experiments/rtp-hdrext/playout-delay"; 76 "http://www.webrtc.org/experiments/rtp-hdrext/playout-delay";
77 const int RtpExtension::kPlayoutDelayDefaultId = 6; 77 const int RtpExtension::kPlayoutDelayDefaultId = 6;
78 78
79 const char* RtpExtension::kVideoContentTypeUri = 79 const char RtpExtension::kVideoContentTypeUri[] =
80 "http://www.webrtc.org/experiments/rtp-hdrext/video-content-type"; 80 "http://www.webrtc.org/experiments/rtp-hdrext/video-content-type";
81 const int RtpExtension::kVideoContentTypeDefaultId = 7; 81 const int RtpExtension::kVideoContentTypeDefaultId = 7;
82 82
83 const char* RtpExtension::kVideoTimingUri = 83 const char RtpExtension::kVideoTimingUri[] =
84 "http://www.webrtc.org/experiments/rtp-hdrext/video-timing"; 84 "http://www.webrtc.org/experiments/rtp-hdrext/video-timing";
85 const int RtpExtension::kVideoTimingDefaultId = 8; 85 const int RtpExtension::kVideoTimingDefaultId = 8;
86 86
87 const char* RtpExtension::kEncryptHeaderExtensionsUri = 87 const char RtpExtension::kEncryptHeaderExtensionsUri[] =
88 "urn:ietf:params:rtp-hdrext:encrypt"; 88 "urn:ietf:params:rtp-hdrext:encrypt";
89 89
90 const int RtpExtension::kMinId = 1; 90 const int RtpExtension::kMinId = 1;
91 const int RtpExtension::kMaxId = 14; 91 const int RtpExtension::kMaxId = 14;
92 92
93 bool RtpExtension::IsSupportedForAudio(const std::string& uri) { 93 bool RtpExtension::IsSupportedForAudio(const std::string& uri) {
94 return uri == webrtc::RtpExtension::kAudioLevelUri || 94 return uri == webrtc::RtpExtension::kAudioLevelUri ||
95 uri == webrtc::RtpExtension::kTransportSequenceNumberUri; 95 uri == webrtc::RtpExtension::kTransportSequenceNumberUri;
96 } 96 }
97 97
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
274 VideoEncoderConfig::Vp9EncoderSpecificSettings::Vp9EncoderSpecificSettings( 274 VideoEncoderConfig::Vp9EncoderSpecificSettings::Vp9EncoderSpecificSettings(
275 const VideoCodecVP9& specifics) 275 const VideoCodecVP9& specifics)
276 : specifics_(specifics) {} 276 : specifics_(specifics) {}
277 277
278 void VideoEncoderConfig::Vp9EncoderSpecificSettings::FillVideoCodecVp9( 278 void VideoEncoderConfig::Vp9EncoderSpecificSettings::FillVideoCodecVp9(
279 VideoCodecVP9* vp9_settings) const { 279 VideoCodecVP9* vp9_settings) const {
280 *vp9_settings = specifics_; 280 *vp9_settings = specifics_;
281 } 281 }
282 282
283 } // namespace webrtc 283 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/config.h ('k') | webrtc/media/engine/webrtcmediaengine.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698