webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c - Issue 2986163002: Audit of kConstants missing the const qualifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c

Issue 2986163002: Audit of kConstants missing the const qualifier (Closed)

Patch Set: rebase + constexpr Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routins.h ('k') | webrtc/modules/audio_coding/codecs/isac/main/source/arith_routines.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c

diff --git a/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c b/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c

index 69ee414690d3a9a2c2df93daa8e0795de0443167..0a6e26f05e6adb3bdbe863d904fb325264d85b82 100644

--- a/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c

+++ b/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c

@@ -1885,7 +1885,7 @@ const uint16_t kFrameLenCdf[4] = {

0, 21845, 43690, 65535};

/* pointer to cdf array for frame length indicator */

-const uint16_t *kFrameLenCdfPtr[1] = {kFrameLenCdf};

+const uint16_t * const kFrameLenCdfPtr[1] = {kFrameLenCdf};

/* initial cdf index for decoder of frame length indicator */

const uint16_t kFrameLenInitIndex[1] = {1};

@@ -1953,7 +1953,7 @@ const uint16_t kBwCdf[25] = {

62804, 65535};

/* pointer to cdf array for estimated bandwidth */

-const uint16_t *kBwCdfPtr[1] = {kBwCdf};

+const uint16_t * const kBwCdfPtr[1] = {kBwCdf};

/* initial cdf index for decoder of estimated bandwidth*/

const uint16_t kBwInitIndex[1] = {7};