Audit of kConstants missing the const qualifier

webrtc/api/stats/rtcstats_objects.h

 /*
  *  Copyright 2016 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_
 #define WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_
 
 #include <string>
 #include <vector>
 
 #include "webrtc/api/stats/rtcstats.h"
 
 namespace webrtc {
 
 // https://w3c.github.io/webrtc-pc/#idl-def-rtcdatachannelstate
 struct RTCDataChannelState {
-  static const char* kConnecting;
-  static const char* kOpen;
-  static const char* kClosing;
-  static const char* kClosed;
+  static const char* const kConnecting;
+  static const char* const kOpen;
+  static const char* const kClosing;
+  static const char* const kClosed;
 };
 
 // https://w3c.github.io/webrtc-stats/#dom-rtcstatsicecandidatepairstate
 struct RTCStatsIceCandidatePairState {
-  static const char* kFrozen;
-  static const char* kWaiting;
-  static const char* kInProgress;
-  static const char* kFailed;
-  static const char* kSucceeded;
+  static const char* const kFrozen;
+  static const char* const kWaiting;
+  static const char* const kInProgress;
+  static const char* const kFailed;
+  static const char* const kSucceeded;
 };
 
 // https://w3c.github.io/webrtc-pc/#rtcicecandidatetype-enum
 struct RTCIceCandidateType {
-  static const char* kHost;
-  static const char* kSrflx;
-  static const char* kPrflx;
-  static const char* kRelay;
+  static const char* const kHost;
+  static const char* const kSrflx;
+  static const char* const kPrflx;
+  static const char* const kRelay;
 };
 
 // https://w3c.github.io/webrtc-pc/#idl-def-rtcdtlstransportstate
 struct RTCDtlsTransportState {
-  static const char* kNew;
-  static const char* kConnecting;
-  static const char* kConnected;
-  static const char* kClosed;
-  static const char* kFailed;
+  static const char* const kNew;
+  static const char* const kConnecting;
+  static const char* const kConnected;
+  static const char* const kClosed;
+  static const char* const kFailed;
 };
 
 // |RTCMediaStreamTrackStats::kind| is not an enum in the spec but the only
 // valid values are "audio" and "video".
 // https://w3c.github.io/webrtc-stats/#dom-rtcmediastreamtrackstats-kind
 struct RTCMediaStreamTrackKind {
-  static const char* kAudio;
-  static const char* kVideo;
+  static const char* const kAudio;
+  static const char* const kVideo;
 };
 
 // https://w3c.github.io/webrtc-stats/#certificatestats-dict*
 class RTCCertificateStats final : public RTCStats {
  public:
   WEBRTC_RTCSTATS_DECL();
 
   RTCCertificateStats(const std::string& id, int64_t timestamp_us);
   RTCCertificateStats(std::string&& id, int64_t timestamp_us);
   RTCCertificateStats(const RTCCertificateStats& other);
@@ skipping 336 matching lines @@
   // TODO(hbos): Support enum types? "RTCStatsMember<RTCDtlsTransportState>"?
   RTCStatsMember<std::string> dtls_state;
   RTCStatsMember<std::string> selected_candidate_pair_id;
   RTCStatsMember<std::string> local_certificate_id;
   RTCStatsMember<std::string> remote_certificate_id;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_