webrtc/modules/pacing/alr_detector.h - Issue 2986163002: Audit of kConstants missing the const qualifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/pacing/alr_detector.h

Issue 2986163002: Audit of kConstants missing the const qualifier (Closed)

Patch Set: rebase + constexpr Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/pacing/alr_detector.h

diff --git a/webrtc/modules/pacing/alr_detector.h b/webrtc/modules/pacing/alr_detector.h

index 250002d9fb1b91121d6bead5432485ceb10144a9..0dcd9effd006c4343e8b2f6e05850cab20004b2a 100644

--- a/webrtc/modules/pacing/alr_detector.h

+++ b/webrtc/modules/pacing/alr_detector.h

@@ -59,8 +59,8 @@ class AlrDetector {

static constexpr int kDefaultAlrBandwidthUsagePercent = 65;

static constexpr int kDefaultAlrStartBudgetLevelPercent = 80;

static constexpr int kDefaultAlrStopBudgetLevelPercent = 50;

- static const char* kScreenshareProbingBweExperimentName;

- static const char* kStrictPacingAndProbingExperimentName;

+ static const char kScreenshareProbingBweExperimentName[];

+ static const char kStrictPacingAndProbingExperimentName[];

void UpdateBudgetWithElapsedTime(int64_t delta_time_ms);

void UpdateBudgetWithBytesSent(size_t bytes_sent);