Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: webrtc/modules/pacing/alr_detector.h

Issue 2986163002: Audit of kConstants missing the const qualifier (Closed)
Patch Set: rebase + constexpr Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 const char* experiment_name); 52 const char* experiment_name);
53 53
54 // Sent traffic percentage as a function of network capacity used to determine 54 // Sent traffic percentage as a function of network capacity used to determine
55 // application-limited region. ALR region start when bandwidth usage drops 55 // application-limited region. ALR region start when bandwidth usage drops
56 // below kAlrStartUsagePercent and ends when it raises above 56 // below kAlrStartUsagePercent and ends when it raises above
57 // kAlrEndUsagePercent. NOTE: This is intentionally conservative at the moment 57 // kAlrEndUsagePercent. NOTE: This is intentionally conservative at the moment
58 // until BW adjustments of application limited region is fine tuned. 58 // until BW adjustments of application limited region is fine tuned.
59 static constexpr int kDefaultAlrBandwidthUsagePercent = 65; 59 static constexpr int kDefaultAlrBandwidthUsagePercent = 65;
60 static constexpr int kDefaultAlrStartBudgetLevelPercent = 80; 60 static constexpr int kDefaultAlrStartBudgetLevelPercent = 80;
61 static constexpr int kDefaultAlrStopBudgetLevelPercent = 50; 61 static constexpr int kDefaultAlrStopBudgetLevelPercent = 50;
62 static const char* kScreenshareProbingBweExperimentName; 62 static const char kScreenshareProbingBweExperimentName[];
63 static const char* kStrictPacingAndProbingExperimentName; 63 static const char kStrictPacingAndProbingExperimentName[];
64 64
65 void UpdateBudgetWithElapsedTime(int64_t delta_time_ms); 65 void UpdateBudgetWithElapsedTime(int64_t delta_time_ms);
66 void UpdateBudgetWithBytesSent(size_t bytes_sent); 66 void UpdateBudgetWithBytesSent(size_t bytes_sent);
67 67
68 private: 68 private:
69 int bandwidth_usage_percent_; 69 int bandwidth_usage_percent_;
70 int alr_start_budget_level_percent_; 70 int alr_start_budget_level_percent_;
71 int alr_stop_budget_level_percent_; 71 int alr_stop_budget_level_percent_;
72 72
73 IntervalBudget alr_budget_; 73 IntervalBudget alr_budget_;
74 rtc::Optional<int64_t> alr_started_time_ms_; 74 rtc::Optional<int64_t> alr_started_time_ms_;
75 }; 75 };
76 76
77 } // namespace webrtc 77 } // namespace webrtc
78 78
79 #endif // WEBRTC_MODULES_PACING_ALR_DETECTOR_H_ 79 #endif // WEBRTC_MODULES_PACING_ALR_DETECTOR_H_
OLDNEW
« no previous file with comments | « webrtc/modules/audio_processing/level_controller/noise_spectrum_estimator.cc ('k') | webrtc/modules/pacing/alr_detector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698