webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h - Issue 2986163002: Audit of kConstants missing the const qualifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h

Issue 2986163002: Audit of kConstants missing the const qualifier (Closed)

Patch Set: rebase + constexpr Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h

diff --git a/webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h b/webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h

index 470ee37bdab24dca26a7f281fb08fb7060c91a75..21f9e57cad35d2785e89f4ccbe526bb353793cfd 100644

--- a/webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h

+++ b/webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h

@@ -25,7 +25,7 @@ int GetMinBitrateBps();

static const int64_t kBitrateWindowMs = 1000;

-extern const char* kBweTypeHistogram;

+extern const char kBweTypeHistogram[];

enum BweNames {

kReceiverNoExtension = 0,