webrtc/modules/audio_coding/codecs/isac/main/source/arith_routines_hist.c - Issue 2986163002: Audit of kConstants missing the const qualifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/isac/main/source/arith_routines_hist.c

Issue 2986163002: Audit of kConstants missing the const qualifier (Closed)

Patch Set: rebase + constexpr Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/isac/main/source/arith_routines.h ('k') | webrtc/modules/audio_coding/codecs/isac/main/source/entropy_coding.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/isac/main/source/arith_routines_hist.c

diff --git a/webrtc/modules/audio_coding/codecs/isac/main/source/arith_routines_hist.c b/webrtc/modules/audio_coding/codecs/isac/main/source/arith_routines_hist.c

index 47bbe31b8ae4d9e898cfabea845adb7ffb912fcc..b229c679fc0a1f9fbf8a74fe043608128260f83b 100644

--- a/webrtc/modules/audio_coding/codecs/isac/main/source/arith_routines_hist.c

+++ b/webrtc/modules/audio_coding/codecs/isac/main/source/arith_routines_hist.c

@@ -17,7 +17,7 @@

void WebRtcIsac_EncHistMulti(Bitstr *streamdata, /* in-/output struct containing bitstream */

const int *data, /* input: data vector */

- const uint16_t **cdf, /* input: array of cdf arrays */

+ const uint16_t *const *cdf, /* input: array of cdf arrays */

const int N) /* input: data vector length */

{

uint32_t W_lower, W_upper;

@@ -84,7 +84,7 @@ void WebRtcIsac_EncHistMulti(Bitstr *streamdata, /* in-/output struct containing

int WebRtcIsac_DecHistBisectMulti(int *data, /* output: data vector */

Bitstr *streamdata, /* in-/output struct containing bitstream */

- const uint16_t **cdf, /* input: array of cdf arrays */

+ const uint16_t *const *cdf, /* input: array of cdf arrays */

const uint16_t *cdf_size, /* input: array of cdf table sizes+1 (power of two: 2^k) */

const int N) /* input: data vector length */

{

@@ -192,7 +192,7 @@ int WebRtcIsac_DecHistBisectMulti(int *data, /* output: data vector */

int WebRtcIsac_DecHistOneStepMulti(int *data, /* output: data vector */

Bitstr *streamdata, /* in-/output struct containing bitstream */

- const uint16_t **cdf, /* input: array of cdf arrays */

+ const uint16_t *const *cdf, /* input: array of cdf arrays */

const uint16_t *init_index, /* input: vector of initial cdf table search entries */

const int N) /* input: data vector length */

{