Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: webrtc/config.h

Issue 2986163002: Audit of kConstants missing the const qualifier (Closed)
Patch Set: rebase + constexpr Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/stats/rtcstats_objects.h ('k') | webrtc/config.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 const std::string& uri); 78 const std::string& uri);
79 79
80 // Return a list of RTP header extensions with the non-encrypted extensions 80 // Return a list of RTP header extensions with the non-encrypted extensions
81 // removed if both the encrypted and non-encrypted extension is present for 81 // removed if both the encrypted and non-encrypted extension is present for
82 // the same URI. 82 // the same URI.
83 static std::vector<RtpExtension> FilterDuplicateNonEncrypted( 83 static std::vector<RtpExtension> FilterDuplicateNonEncrypted(
84 const std::vector<RtpExtension>& extensions); 84 const std::vector<RtpExtension>& extensions);
85 85
86 // Header extension for audio levels, as defined in: 86 // Header extension for audio levels, as defined in:
87 // http://tools.ietf.org/html/draft-ietf-avtext-client-to-mixer-audio-level-03 87 // http://tools.ietf.org/html/draft-ietf-avtext-client-to-mixer-audio-level-03
88 static const char* kAudioLevelUri; 88 static const char kAudioLevelUri[];
89 static const int kAudioLevelDefaultId; 89 static const int kAudioLevelDefaultId;
90 90
91 // Header extension for RTP timestamp offset, see RFC 5450 for details: 91 // Header extension for RTP timestamp offset, see RFC 5450 for details:
92 // http://tools.ietf.org/html/rfc5450 92 // http://tools.ietf.org/html/rfc5450
93 static const char* kTimestampOffsetUri; 93 static const char kTimestampOffsetUri[];
94 static const int kTimestampOffsetDefaultId; 94 static const int kTimestampOffsetDefaultId;
95 95
96 // Header extension for absolute send time, see url for details: 96 // Header extension for absolute send time, see url for details:
97 // http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time 97 // http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time
98 static const char* kAbsSendTimeUri; 98 static const char kAbsSendTimeUri[];
99 static const int kAbsSendTimeDefaultId; 99 static const int kAbsSendTimeDefaultId;
100 100
101 // Header extension for coordination of video orientation, see url for 101 // Header extension for coordination of video orientation, see url for
102 // details: 102 // details:
103 // http://www.etsi.org/deliver/etsi_ts/126100_126199/126114/12.07.00_60/ts_126 114v120700p.pdf 103 // http://www.etsi.org/deliver/etsi_ts/126100_126199/126114/12.07.00_60/ts_126 114v120700p.pdf
104 static const char* kVideoRotationUri; 104 static const char kVideoRotationUri[];
105 static const int kVideoRotationDefaultId; 105 static const int kVideoRotationDefaultId;
106 106
107 // Header extension for video content type. E.g. default or screenshare. 107 // Header extension for video content type. E.g. default or screenshare.
108 static const char* kVideoContentTypeUri; 108 static const char kVideoContentTypeUri[];
109 static const int kVideoContentTypeDefaultId; 109 static const int kVideoContentTypeDefaultId;
110 110
111 // Header extension for video timing. 111 // Header extension for video timing.
112 static const char* kVideoTimingUri; 112 static const char kVideoTimingUri[];
113 static const int kVideoTimingDefaultId; 113 static const int kVideoTimingDefaultId;
114 114
115 // Header extension for transport sequence number, see url for details: 115 // Header extension for transport sequence number, see url for details:
116 // http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions 116 // http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions
117 static const char* kTransportSequenceNumberUri; 117 static const char kTransportSequenceNumberUri[];
118 static const int kTransportSequenceNumberDefaultId; 118 static const int kTransportSequenceNumberDefaultId;
119 119
120 static const char* kPlayoutDelayUri; 120 static const char kPlayoutDelayUri[];
121 static const int kPlayoutDelayDefaultId; 121 static const int kPlayoutDelayDefaultId;
122 122
123 // Encryption of Header Extensions, see RFC 6904 for details: 123 // Encryption of Header Extensions, see RFC 6904 for details:
124 // https://tools.ietf.org/html/rfc6904 124 // https://tools.ietf.org/html/rfc6904
125 static const char* kEncryptHeaderExtensionsUri; 125 static const char kEncryptHeaderExtensionsUri[];
126 126
127 // Inclusive min and max IDs for one-byte header extensions, per RFC5285. 127 // Inclusive min and max IDs for one-byte header extensions, per RFC5285.
128 static const int kMinId; 128 static const int kMinId;
129 static const int kMaxId; 129 static const int kMaxId;
130 130
131 std::string uri; 131 std::string uri;
132 int id = 0; 132 int id = 0;
133 bool encrypt = false; 133 bool encrypt = false;
134 }; 134 };
135 135
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 257
258 private: 258 private:
259 // Access to the copy constructor is private to force use of the Copy() 259 // Access to the copy constructor is private to force use of the Copy()
260 // method for those exceptional cases where we do use it. 260 // method for those exceptional cases where we do use it.
261 VideoEncoderConfig(const VideoEncoderConfig&); 261 VideoEncoderConfig(const VideoEncoderConfig&);
262 }; 262 };
263 263
264 } // namespace webrtc 264 } // namespace webrtc
265 265
266 #endif // WEBRTC_CONFIG_H_ 266 #endif // WEBRTC_CONFIG_H_
OLDNEW
« no previous file with comments | « webrtc/api/stats/rtcstats_objects.h ('k') | webrtc/config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698