Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: webrtc/stats/rtcstats_objects.cc

Issue 2986163002: Audit of kConstants missing the const qualifier (Closed)
Patch Set: rebase + constexpr Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/rtc_base/sslroots.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/api/stats/rtcstats_objects.h" 11 #include "webrtc/api/stats/rtcstats_objects.h"
12 12
13 namespace webrtc { 13 namespace webrtc {
14 14
15 const char* RTCDataChannelState::kConnecting = "connecting"; 15 const char* const RTCDataChannelState::kConnecting = "connecting";
16 const char* RTCDataChannelState::kOpen = "open"; 16 const char* const RTCDataChannelState::kOpen = "open";
17 const char* RTCDataChannelState::kClosing = "closing"; 17 const char* const RTCDataChannelState::kClosing = "closing";
18 const char* RTCDataChannelState::kClosed = "closed"; 18 const char* const RTCDataChannelState::kClosed = "closed";
19 19
20 const char* RTCStatsIceCandidatePairState::kFrozen = "frozen"; 20 const char* const RTCStatsIceCandidatePairState::kFrozen = "frozen";
21 const char* RTCStatsIceCandidatePairState::kWaiting = "waiting"; 21 const char* const RTCStatsIceCandidatePairState::kWaiting = "waiting";
22 const char* RTCStatsIceCandidatePairState::kInProgress = "in-progress"; 22 const char* const RTCStatsIceCandidatePairState::kInProgress = "in-progress";
23 const char* RTCStatsIceCandidatePairState::kFailed = "failed"; 23 const char* const RTCStatsIceCandidatePairState::kFailed = "failed";
24 const char* RTCStatsIceCandidatePairState::kSucceeded = "succeeded"; 24 const char* const RTCStatsIceCandidatePairState::kSucceeded = "succeeded";
25 25
26 // Strings defined in https://tools.ietf.org/html/rfc5245. 26 // Strings defined in https://tools.ietf.org/html/rfc5245.
27 const char* RTCIceCandidateType::kHost = "host"; 27 const char* const RTCIceCandidateType::kHost = "host";
28 const char* RTCIceCandidateType::kSrflx = "srflx"; 28 const char* const RTCIceCandidateType::kSrflx = "srflx";
29 const char* RTCIceCandidateType::kPrflx = "prflx"; 29 const char* const RTCIceCandidateType::kPrflx = "prflx";
30 const char* RTCIceCandidateType::kRelay = "relay"; 30 const char* const RTCIceCandidateType::kRelay = "relay";
31 31
32 const char* RTCDtlsTransportState::kNew = "new"; 32 const char* const RTCDtlsTransportState::kNew = "new";
33 const char* RTCDtlsTransportState::kConnecting = "connecting"; 33 const char* const RTCDtlsTransportState::kConnecting = "connecting";
34 const char* RTCDtlsTransportState::kConnected = "connected"; 34 const char* const RTCDtlsTransportState::kConnected = "connected";
35 const char* RTCDtlsTransportState::kClosed = "closed"; 35 const char* const RTCDtlsTransportState::kClosed = "closed";
36 const char* RTCDtlsTransportState::kFailed = "failed"; 36 const char* const RTCDtlsTransportState::kFailed = "failed";
37 37
38 const char* RTCMediaStreamTrackKind::kAudio = "audio"; 38 const char* const RTCMediaStreamTrackKind::kAudio = "audio";
39 const char* RTCMediaStreamTrackKind::kVideo = "video"; 39 const char* const RTCMediaStreamTrackKind::kVideo = "video";
40 40
41 WEBRTC_RTCSTATS_IMPL(RTCCertificateStats, RTCStats, "certificate", 41 WEBRTC_RTCSTATS_IMPL(RTCCertificateStats, RTCStats, "certificate",
42 &fingerprint, 42 &fingerprint,
43 &fingerprint_algorithm, 43 &fingerprint_algorithm,
44 &base64_certificate, 44 &base64_certificate,
45 &issuer_certificate_id); 45 &issuer_certificate_id);
46 46
47 RTCCertificateStats::RTCCertificateStats( 47 RTCCertificateStats::RTCCertificateStats(
48 const std::string& id, int64_t timestamp_us) 48 const std::string& id, int64_t timestamp_us)
49 : RTCCertificateStats(std::string(id), timestamp_us) { 49 : RTCCertificateStats(std::string(id), timestamp_us) {
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 dtls_state(other.dtls_state), 652 dtls_state(other.dtls_state),
653 selected_candidate_pair_id(other.selected_candidate_pair_id), 653 selected_candidate_pair_id(other.selected_candidate_pair_id),
654 local_certificate_id(other.local_certificate_id), 654 local_certificate_id(other.local_certificate_id),
655 remote_certificate_id(other.remote_certificate_id) { 655 remote_certificate_id(other.remote_certificate_id) {
656 } 656 }
657 657
658 RTCTransportStats::~RTCTransportStats() { 658 RTCTransportStats::~RTCTransportStats() {
659 } 659 }
660 660
661 } // namespace webrtc 661 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/rtc_base/sslroots.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698