Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1228913003: Remove empty-string comparisons. (Closed)

Created:
5 years, 5 months ago by pbos-webrtc
Modified:
5 years, 5 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, hlundin-webrtc, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, mflodman, kwiberg-webrtc, andresp, perkj_webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove empty-string comparisons. Use .empty() and !.empty() in favor of == "" or != "". BUG= R=tommi@webrtc.org Committed: https://crrev.com/bb36fdf95f9667fb1f3fbf3073bd15007681322c Cr-Commit-Position: refs/heads/master@{#9559}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M talk/app/webrtc/webrtcsdp.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/audioproc_float.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/transient/transient_suppression_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/tools/video_quality_measurement.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/main/test/test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/test/video_rtp_play.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/test/field_trial.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/agc/agc_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/replay.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
pbos-webrtc
PTAL
5 years, 5 months ago (2015-07-09 12:10:12 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228913003/1
5 years, 5 months ago (2015-07-09 12:10:29 UTC) #3
pbos-webrtc
Oh, and pay special attention to != "" properly being translated to !foo.empty() instead of ...
5 years, 5 months ago (2015-07-09 12:10:55 UTC) #4
tommi
lgtm
5 years, 5 months ago (2015-07-09 12:16:40 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-09 13:09:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228913003/1
5 years, 5 months ago (2015-07-09 14:47:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 14:48:20 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 14:48:38 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bb36fdf95f9667fb1f3fbf3073bd15007681322c
Cr-Commit-Position: refs/heads/master@{#9559}

Powered by Google App Engine
This is Rietveld 408576698