Remove empty-string comparisons.

webrtc/video/replay.cc

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 88 matching lines @@
 static int TransmissionOffsetId() {
   return static_cast<int>(FLAGS_transmission_offset_id);
 }
 static const bool timestamp_offset_dummy =
     google::RegisterFlagValidator(&FLAGS_transmission_offset_id,
                                   &ValidateRtpHeaderExtensionId);
 
 // Flag for rtpdump input file.
 bool ValidateInputFilenameNotEmpty(const char* flagname,
                                    const std::string& string) {
-  return string != "";
+  return !string.empty();
 }
 
 DEFINE_string(input_file, "", "input file");
 static std::string InputFile() {
   return static_cast<std::string>(FLAGS_input_file);
 }
 static const bool input_file_dummy =
     google::RegisterFlagValidator(&FLAGS_input_file,
                                   &ValidateInputFilenameNotEmpty);
 
@@ skipping 29 matching lines @@
   ~FileRenderPassthrough() {
     if (file_ != nullptr)
       fclose(file_);
   }
 
  private:
   void RenderFrame(const VideoFrame& video_frame,
                    int time_to_render_ms) override {
     if (renderer_ != nullptr)
       renderer_->RenderFrame(video_frame, time_to_render_ms);
-    if (basename_ == "")
+    if (basename_.empty())
       return;
     if (last_width_ != video_frame.width() ||
         last_height_ != video_frame.height()) {
       if (file_ != nullptr)
         fclose(file_);
       std::stringstream filename;
       filename << basename_;
       if (++count_ > 1)
         filename << '-' << count_;
       filename << '_' << video_frame.width() << 'x' << video_frame.height()
@@ skipping 64 matching lines @@
     receive_config.rtp.extensions.push_back(
         RtpExtension(RtpExtension::kAbsSendTime, flags::AbsSendTimeId()));
   }
   receive_config.renderer = &file_passthrough;
 
   VideoSendStream::Config::EncoderSettings encoder_settings;
   encoder_settings.payload_name = flags::Codec();
   encoder_settings.payload_type = flags::PayloadType();
   VideoReceiveStream::Decoder decoder;
   rtc::scoped_ptr<DecoderBitstreamFileWriter> bitstream_writer;
-  if (flags::DecoderBitstreamFilename() != "") {
+  if (!flags::DecoderBitstreamFilename().empty()) {
     bitstream_writer.reset(new DecoderBitstreamFileWriter(
         flags::DecoderBitstreamFilename().c_str()));
     receive_config.pre_decode_callback = bitstream_writer.get();
   }
   decoder = test::CreateMatchingDecoder(encoder_settings);
-  if (flags::DecoderBitstreamFilename() != "") {
+  if (!flags::DecoderBitstreamFilename().empty()) {
     // Replace with a null decoder if we're writing the bitstream to a file
     // instead.
     delete decoder.decoder;
     decoder.decoder = new test::FakeNullDecoder();
   }
   receive_config.decoders.push_back(decoder);
 
   VideoReceiveStream* receive_stream =
       call->CreateVideoReceiveStream(receive_config);
 
@@ skipping 63 matching lines @@
 }
 }  // namespace webrtc
 
 int main(int argc, char* argv[]) {
   ::testing::InitGoogleTest(&argc, argv);
   google::ParseCommandLineFlags(&argc, &argv, true);
 
   webrtc::test::RunTest(webrtc::RtpReplay);
   return 0;
 }