Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: webrtc/modules/audio_processing/test/audioproc_float.cc

Issue 1228913003: Remove empty-string comparisons. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/test/audioproc_float.cc
diff --git a/webrtc/modules/audio_processing/test/audioproc_float.cc b/webrtc/modules/audio_processing/test/audioproc_float.cc
index 381d7fd2b6750886974771e6a172aa70088d1335..dac43629cf65d69151f34b83f3b1a4f8e0c1aa79 100644
--- a/webrtc/modules/audio_processing/test/audioproc_float.cc
+++ b/webrtc/modules/audio_processing/test/audioproc_float.cc
@@ -64,12 +64,12 @@ int main(int argc, char* argv[]) {
google::SetUsageMessage(kUsage);
google::ParseCommandLineFlags(&argc, &argv, true);
- if (!((FLAGS_i == "") ^ (FLAGS_dump == ""))) {
+ if (!((FLAGS_i.empty()) ^ (FLAGS_dump.empty()))) {
fprintf(stderr,
"An input file must be specified with either -i or -dump.\n");
return 1;
}
- if (FLAGS_dump != "") {
+ if (!FLAGS_dump.empty()) {
fprintf(stderr, "FIXME: the -dump option is not yet implemented.\n");
return 1;
}
@@ -96,7 +96,7 @@ int main(int argc, char* argv[]) {
}
rtc::scoped_ptr<AudioProcessing> ap(AudioProcessing::Create(config));
- if (FLAGS_dump != "") {
+ if (!FLAGS_dump.empty()) {
CHECK_EQ(kNoErr, ap->echo_cancellation()->Enable(FLAGS_aec || FLAGS_all));
} else if (FLAGS_aec) {
fprintf(stderr, "-aec requires a -dump file.\n");

Powered by Google App Engine
This is Rietveld 408576698