webrtc/modules/audio_processing/test/audio_processing_unittest.cc - Issue 1228913003: Remove empty-string comparisons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/test/audio_processing_unittest.cc

Issue 1228913003: Remove empty-string comparisons. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_processing/test/audio_processing_unittest.cc

diff --git a/webrtc/modules/audio_processing/test/audio_processing_unittest.cc b/webrtc/modules/audio_processing/test/audio_processing_unittest.cc

index c7c45f7eeba0ab6d9dddaf53cad10c2a3b4b8630..291035a01205d76b19258030ffeb20ba8ee0c06f 100644

--- a/webrtc/modules/audio_processing/test/audio_processing_unittest.cc

+++ b/webrtc/modules/audio_processing/test/audio_processing_unittest.cc

@@ -269,7 +269,7 @@ std::string OutputFilePath(std::string name,

ss << output_rate / 1000 << "_pcm";

std::string filename = ss.str();

- if (temp_filenames[filename] == "")

+ if (temp_filenames[filename].empty())

temp_filenames[filename] = test::TempFilename(test::OutputPath(), filename);

return temp_filenames[filename];

}