talk/app/webrtc/webrtcsdp.cc - Issue 1228913003: Remove empty-string comparisons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/webrtcsdp.cc

Issue 1228913003: Remove empty-string comparisons. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: talk/app/webrtc/webrtcsdp.cc

diff --git a/talk/app/webrtc/webrtcsdp.cc b/talk/app/webrtc/webrtcsdp.cc

index 9d647955d1fa4df9c33583a25778a3994dea5a8a..b6f23ca9d00577e9ae7e4834bd128a8efbecdd0e 100644

--- a/talk/app/webrtc/webrtcsdp.cc

+++ b/talk/app/webrtc/webrtcsdp.cc

@@ -2192,7 +2192,7 @@ bool ParseMediaDescription(const std::string& message,

for (size_t j = 3 ; j < fields.size(); ++j) {

// TODO(wu): Remove when below bug is fixed.

// https://bugzilla.mozilla.org/show_bug.cgi?id=996329

- if (fields[j] == "" && j == fields.size() - 1) {

+ if (fields[j].empty() && j == fields.size() - 1) {

continue;

}

« no previous file with comments | « no previous file | webrtc/modules/audio_processing/test/audio_processing_unittest.cc » ('j') | no next file with comments »