webrtc/modules/audio_processing/transient/transient_suppression_test.cc - Issue 1228913003: Remove empty-string comparisons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/transient/transient_suppression_test.cc

Issue 1228913003: Remove empty-string comparisons. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/test/audioproc_float.cc ('k') | webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/transient/transient_suppression_test.cc

diff --git a/webrtc/modules/audio_processing/transient/transient_suppression_test.cc b/webrtc/modules/audio_processing/transient/transient_suppression_test.cc

index fdc56867637cce04f5270c823e224c73430904d6..506abaf2036843497cf2543745729ad714ceef35 100644

--- a/webrtc/modules/audio_processing/transient/transient_suppression_test.cc

+++ b/webrtc/modules/audio_processing/transient/transient_suppression_test.cc

@@ -150,13 +150,13 @@ void void_main() {

// Prepare the detection file.

FILE* detection_file = NULL;

- if (FLAGS_detection_file_name != "") {

+ if (!FLAGS_detection_file_name.empty()) {

detection_file = fopen(FLAGS_detection_file_name.c_str(), "rb");

}

// Prepare the reference file.

FILE* reference_file = NULL;

- if (FLAGS_reference_file_name != "") {

+ if (!FLAGS_reference_file_name.empty()) {

reference_file = fopen(FLAGS_reference_file_name.c_str(), "rb");

}