webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.cc - Issue 1228913003: Remove empty-string comparisons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.cc

Issue 1228913003: Remove empty-string comparisons. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.cc b/webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.cc

index 319a97bfcaa749703545f8da61beec7b5e9fe5b6..de13023b2640763e6c5c5064ee3102d578acfb80 100644

--- a/webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.cc

+++ b/webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.cc

@@ -116,9 +116,9 @@ Logging::State::State(const std::string& tag, int64_t timestamp_ms,

}

void Logging::State::MergePrevious(const State& previous) {

- if (tag == "") {

+ if (tag.empty()) {

tag = previous.tag;

- } else if (previous.tag != "") {

+ } else if (!previous.tag.empty()) {

tag = previous.tag + "_" + tag;

}

timestamp_ms = std::max(previous.timestamp_ms, timestamp_ms);