webrtc/video/end_to_end_tests.cc - Issue 1228913003: Remove empty-string comparisons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 1228913003: Remove empty-string comparisons. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/video/end_to_end_tests.cc

diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc

index dd9650db05232a1838eee2b0a4fd1469fffecc41..82fbe3ae529f7d05e993573a1dbf24a42d5252e6 100644

--- a/webrtc/video/end_to_end_tests.cc

+++ b/webrtc/video/end_to_end_tests.cc

@@ -2001,7 +2001,7 @@ TEST_F(EndToEndTest, GetStats) {

stats.frame_counts.key_frames != 0 ||

stats.frame_counts.delta_frames != 0;

- receive_stats_filled_["CName"] |= stats.c_name != "";

+ receive_stats_filled_["CName"] |= !stats.c_name.empty();

receive_stats_filled_["RtcpPacketTypeCount"] |=

stats.rtcp_packet_type_counts.fir_packets != 0 ||

« no previous file with comments | « webrtc/tools/agc/agc_test.cc ('k') | webrtc/video/replay.cc » ('j') | no next file with comments »