Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: webrtc/video/end_to_end_tests.cc

Issue 1228913003: Remove empty-string comparisons. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/tools/agc/agc_test.cc ('k') | webrtc/video/replay.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <algorithm> 10 #include <algorithm>
(...skipping 1983 matching lines...) Expand 10 before | Expand all | Expand 10 after
1994 stats.rtp_stats.transmitted.padding_bytes != 0 || 1994 stats.rtp_stats.transmitted.padding_bytes != 0 ||
1995 stats.rtp_stats.retransmitted.packets != 0; 1995 stats.rtp_stats.retransmitted.packets != 0;
1996 1996
1997 receive_stats_filled_["CodecStats"] |= 1997 receive_stats_filled_["CodecStats"] |=
1998 stats.target_delay_ms != 0 || stats.discarded_packets != 0; 1998 stats.target_delay_ms != 0 || stats.discarded_packets != 0;
1999 1999
2000 receive_stats_filled_["FrameCounts"] |= 2000 receive_stats_filled_["FrameCounts"] |=
2001 stats.frame_counts.key_frames != 0 || 2001 stats.frame_counts.key_frames != 0 ||
2002 stats.frame_counts.delta_frames != 0; 2002 stats.frame_counts.delta_frames != 0;
2003 2003
2004 receive_stats_filled_["CName"] |= stats.c_name != ""; 2004 receive_stats_filled_["CName"] |= !stats.c_name.empty();
2005 2005
2006 receive_stats_filled_["RtcpPacketTypeCount"] |= 2006 receive_stats_filled_["RtcpPacketTypeCount"] |=
2007 stats.rtcp_packet_type_counts.fir_packets != 0 || 2007 stats.rtcp_packet_type_counts.fir_packets != 0 ||
2008 stats.rtcp_packet_type_counts.nack_packets != 0 || 2008 stats.rtcp_packet_type_counts.nack_packets != 0 ||
2009 stats.rtcp_packet_type_counts.pli_packets != 0 || 2009 stats.rtcp_packet_type_counts.pli_packets != 0 ||
2010 stats.rtcp_packet_type_counts.nack_requests != 0 || 2010 stats.rtcp_packet_type_counts.nack_requests != 0 ||
2011 stats.rtcp_packet_type_counts.unique_nack_requests != 0; 2011 stats.rtcp_packet_type_counts.unique_nack_requests != 0;
2012 } 2012 }
2013 2013
2014 return AllStatsFilled(receive_stats_filled_); 2014 return AllStatsFilled(receive_stats_filled_);
(...skipping 816 matching lines...) Expand 10 before | Expand all | Expand 10 after
2831 EXPECT_TRUE(default_receive_config.rtp.rtx.empty()) 2831 EXPECT_TRUE(default_receive_config.rtp.rtx.empty())
2832 << "Enabling RTX requires rtpmap: rtx negotiation."; 2832 << "Enabling RTX requires rtpmap: rtx negotiation.";
2833 EXPECT_TRUE(default_receive_config.rtp.extensions.empty()) 2833 EXPECT_TRUE(default_receive_config.rtp.extensions.empty())
2834 << "Enabling RTP extensions require negotiation."; 2834 << "Enabling RTP extensions require negotiation.";
2835 2835
2836 VerifyEmptyNackConfig(default_receive_config.rtp.nack); 2836 VerifyEmptyNackConfig(default_receive_config.rtp.nack);
2837 VerifyEmptyFecConfig(default_receive_config.rtp.fec); 2837 VerifyEmptyFecConfig(default_receive_config.rtp.fec);
2838 } 2838 }
2839 2839
2840 } // namespace webrtc 2840 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/tools/agc/agc_test.cc ('k') | webrtc/video/replay.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698