Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: webrtc/modules/video_coding/main/test/video_rtp_play.cc

Issue 1228913003: Remove empty-string comparisons. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/video_coding/main/test/test_util.cc ('k') | webrtc/test/field_trial.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 26 matching lines...) Expand all
37 37
38 webrtc::rtpplayer::PayloadTypes payload_types; 38 webrtc::rtpplayer::PayloadTypes payload_types;
39 payload_types.push_back(webrtc::rtpplayer::PayloadCodecTuple( 39 payload_types.push_back(webrtc::rtpplayer::PayloadCodecTuple(
40 kDefaultUlpFecPayloadType, "ULPFEC", webrtc::kVideoCodecULPFEC)); 40 kDefaultUlpFecPayloadType, "ULPFEC", webrtc::kVideoCodecULPFEC));
41 payload_types.push_back(webrtc::rtpplayer::PayloadCodecTuple( 41 payload_types.push_back(webrtc::rtpplayer::PayloadCodecTuple(
42 kDefaultRedPayloadType, "RED", webrtc::kVideoCodecRED)); 42 kDefaultRedPayloadType, "RED", webrtc::kVideoCodecRED));
43 payload_types.push_back(webrtc::rtpplayer::PayloadCodecTuple( 43 payload_types.push_back(webrtc::rtpplayer::PayloadCodecTuple(
44 kDefaultVp8PayloadType, "VP8", webrtc::kVideoCodecVP8)); 44 kDefaultVp8PayloadType, "VP8", webrtc::kVideoCodecVP8));
45 45
46 std::string output_file = args.outputFile; 46 std::string output_file = args.outputFile;
47 if (output_file == "") { 47 if (output_file.empty())
48 output_file = webrtc::test::OutputPath() + "RtpPlay_decoded.yuv"; 48 output_file = webrtc::test::OutputPath() + "RtpPlay_decoded.yuv";
49 }
50 49
51 webrtc::SimulatedClock clock(0); 50 webrtc::SimulatedClock clock(0);
52 webrtc::rtpplayer::VcmPayloadSinkFactory factory(output_file, &clock, 51 webrtc::rtpplayer::VcmPayloadSinkFactory factory(output_file, &clock,
53 kConfigProtectionEnabled, kConfigProtectionMethod, kConfigRttMs, 52 kConfigProtectionEnabled, kConfigProtectionMethod, kConfigRttMs,
54 kConfigRenderDelayMs, kConfigMinPlayoutDelayMs); 53 kConfigRenderDelayMs, kConfigMinPlayoutDelayMs);
55 rtc::scoped_ptr<webrtc::rtpplayer::RtpPlayerInterface> rtp_player( 54 rtc::scoped_ptr<webrtc::rtpplayer::RtpPlayerInterface> rtp_player(
56 webrtc::rtpplayer::Create(args.inputFile, &factory, &clock, payload_types, 55 webrtc::rtpplayer::Create(args.inputFile, &factory, &clock, payload_types,
57 kConfigLossRate, kConfigRttMs, 56 kConfigLossRate, kConfigRttMs,
58 kConfigReordering)); 57 kConfigReordering));
59 if (rtp_player.get() == NULL) { 58 if (rtp_player.get() == NULL) {
(...skipping 20 matching lines...) Expand all
80 printf("Failed\n"); 79 printf("Failed\n");
81 return -1; 80 return -1;
82 case 0: 81 case 0:
83 printf("Timeout\n"); 82 printf("Timeout\n");
84 return -1; 83 return -1;
85 } 84 }
86 85
87 webrtc::Trace::ReturnTrace(); 86 webrtc::Trace::ReturnTrace();
88 return 0; 87 return 0;
89 } 88 }
OLDNEW
« no previous file with comments | « webrtc/modules/video_coding/main/test/test_util.cc ('k') | webrtc/test/field_trial.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698